kitty @0.11.3 (aqua): "command execution failed" after upgrade to Mojave 10.14

[RCIIIcm]

Followed instructions at ​https://trac.macports.org/wiki/Migration. Only port that failed to install was kitty. Did sudo port clean kitty;sudo port install kitty, same issue. Log attached

[kencu (Ken)]

I'm not sure why any port would want to error out on -Wdeprecated-declarations. That seems kinda silly.

:info:build /usr/bin/clang -MMD -D_XOPEN_SOURCE=700 -DNDEBUG -DPRIMARY_VERSION=4000 -DSECONDARY_VERSION=11 -DDUMP_COMMANDS -Wextra -Wno-missing-field-initializers -Wall -std=c99 -pedantic-errors -Werror -O3 -fwrapv -fstack-protector-strong -pipe -march=native -fvisibility=hidden -arch x86_64 -flto -pthread -I/opt/local/include/libpng16 -I/opt/local/include/harfbuzz -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m -I/opt/local/Library/Frameworks/Python.framework/Versions/3.7/include/python3.7m -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_kitty/kitty/work/kitty-0.11.3/kitty/parser.c -o /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_kitty/kitty/work/kitty-0.11.3/build/fast_data_types-parser_dump.c.o/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_kitty/kitty/work/kitty-0.11.3/glfw/nsgl_context.m:35:26: error: 'NSOpenGLContext' is deprecated: first deprecated in macOS 10.14 - Please use Metal or MetalKit. [-Werror,-Wdeprecated-declarations]

[kencu (Ken)]

and FYI, it's been updated:

$ port livecheck kitty
kitty seems to have been updated (port version: 0.11.3, new version: 0.12.3)

[ken-cunningham-webuse]

In 7d5813e6ff526eb52de1db6d0300d4056ca132cc/macports-ports (master):

kitty: don't warn on deprecated-declarations

fixes build error with -Werror enabled
closes: #57483

[jmroot (Joshua Root)]

Better to turn off -Werror entirely than to play whack-a-mole turning off warnings each time a new compiler version comes out.

[kencu (Ken)]

That was indeed my first plan -- the setup.py files are full of python code I don't follow so perfectly, and the place to add the -Wno-deprecated-declarations just was staring me in the face there, so I took that one.

I think we should always have -Werror turned off if we can. It's 99% of the time a useless PITA for a distribution like this.

[kencu (Ken)]

In this line here:

-pedantic-errors -Werror {} {} -fwrapv {} {} -pipe {} -fvisibility=hidden

what are all those {} {} there for? Could I have just deleted the -Werror out of that line instead?