Opened 4 months ago

Closed 2 months ago

#57581 closed defect (fixed)

missing dependencies for tkx-ed and tkx-prove

Reported by: chrstphrchvz (Christopher Chavez) Owned by: chrstphrchvz (Christopher Chavez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mojca (Mojca Miklavec)
Port: p5-tkx

Description

p5.xx-tkx currently installs two demo scripts as binaries, tkx-ed-5.xx (simple text editor) and tkx-prove-5.xx (GUI for running tests). However p5.xx-tkx does not require some dependencies used by those scripts.

tkx-ed (simple text editor):

  • requires BWidget (available in MacPorts)
  • throws a warning if it can't find tclCarbonProcesses (from CarbonCritLib; not in MacPorts, no longer developed/available?). This is only used to "Set the process name that is displayed in the Activity Monitor and the Force Quit dialog" (the default will be perl5.xx). Unless a different approach without tclCarbonProcess can be used, I think this can be ignored or suppressed by a patch.

tkx-prove (GUI for running tests):

  • requires Test::Harness::Straps, which is obsolete and not in MacPorts; probably it would be better if the script used a replacement module instead. Given that the tests it runs (t/*.t from distribution) aren't installed by MacPorts, this script can probably be removed.

For now, I'm inclined to open a PR that removes tkx-prove and adds BWidget as a dependency so that tkx-ed is usable, if it would be useful to have as a readily available demo. Or, is some other solution more desirable, e.g. removing tkx-ed as well?

Change History (1)

comment:1 Changed 2 months ago by chrstphrchvz (Christopher Chavez)

Owner: set to chrstphrchvz
Resolution: fixed
Status: newclosed

In d23aa5edd6658d6a3e5f5662478d086baf7157c3/macports-ports (master):

p5-tkx: demo improvements

Remove unusable tkx-prove demo

For tkx-ed demo:

  • Add BWidget dependency
  • Remove tclCarbonProcesses usage

Fixes #57581

Note: See TracTickets for help on using tickets.