pdsh and genders

[unix-fan]

hi team, if you're interested, i created an updated portfile for pdsh, and added support for genders. keep up the great work, still prefer macports over brew :) best regards, martin

[ryandesign (Ryan Carsten Schmidt)]

Thanks.

You mentioned an updated pdsh port but I don't see anything attached about that.

In your new port for genders, please:

• Add your GitHub handle to the maintainers line in the usual format.
• Remove the homepage line; the github.setup line sets that for you.
• Remove the master_sites and livecheck.* lines; use github.tarball_from releases instead.
• Remove the comment lines
• Add size to checksums
• Fix the github.setup line. The correct value may be github.setup chaos genders 1-22-1 genders-; then you'll need to fix the version, possibly by setting it to a munged version of ${github.version} where you replace the dashes with periods.

[ryandesign (Ryan Carsten Schmidt)]

I see now that the tag name is genders-1-22-1 but the filename is genders-1.22.tar.gz, so that's confusing and not anticipated by the github portgroup and will require some manual corrections in the portfile.

[unix-fan]

cleaned up Portfile.pdsh.txt.2 and Portfile.genders.txt.3 sorry, i'm not fit enough in macporting to get it to work without master_sites and the livecheck stuff.

[mf2k (Frank Schima)]

There is already an existing pdsh port. Please instead modify that to update to 2.33 and attach a ​unified diff of the Portfile.

[unix-fan]

undid whitespace changes

[mf2k (Frank Schima)]

You have removed the previous maintainer from pdsh.

@ james.trammell: Are you OK with that?

[unix-fan]

sorry, wasnt aware you can have more than one maintainer. i sent mail to james.trammell some time ago, didn't answer though. all this just to have the latest pdsh in macports :)

[mf2k (Frank Schima)]

Well we don't want to step on anyone's toes. Although it does look like this maintainer is inactive. Last activity was 2015 when the port was created with him as maintainer.

[mf2k (Frank Schima)]

Some comments on your pdsh patch:

• You should be able to remove the master_sites line by setting github.tarball_from releases
• There are too many variants being added IMHO. Can they all just be incorporated directly and not make them variants at all?
• For the no_rsh variant, we long ago excised such "negative" variants for consistency. You made it the default, so is there a reason not to have rsh functionality built? If so, name the variant rsh and do not make it a default variant.

[unix-fan]

further cleanup

[mf2k (Frank Schima)]

Just to be clear. I want the variants removed entirely. Is there an actual reason to not just always have the functionality turned on? With the exception of the readline functionality, no other dependencies are being added.

[unix-fan]

removed variant rsh, doesnt make much sense anyway, unless you want talk to really old gear.

removed nodeupdown, because i couldn't find an uptodate source repo for it. thought it would be nice for experimenting, but not worth the effort. removed readline option, made it fix, because everyone wants to have it anyway. removed dsh option, made it fix, because it doesnt cost anything to have it supported.

would like to keep genders as an option for fiddling around, because it causes a conflict, when used together with dshgroups, and needs unexpected manual interaction. if it really bothers someone to keep it in there, then no, remove it for gods sake. then you also can ignore the genders portfile, of course.

:)

[mf2k (Frank Schima)]

Looking better, thank you! Do you guys mind if we add openmaintainer to this port too?

[mf2k (Frank Schima)]

BTW, the genders variant is fine to keep.

[mf2k (Frank Schima)]

I have filed #57791 for James. If I don't hear from him in 3 days, I'll commit this with unix-fan as maintainer with openmaintainer.

[jtrammel]

Acknowleged. Thanks, I'm caught up with this thread now.

[mf2k (Frank Schima)]

@jtrammel: Thank you for the reply! I'm happy to keep you as co-maintainer for this port. I will also update for GitHub handle on the port.

[mf2k (Frank Schima)]

In 74092682b472fadeb8f7ad04083cdb268b7298ae/macports-ports (master):

genders: New port

See: #57765

[mf2k (Frank Schima)]

In 7d9c6c5a21fd3a09f73b29d4df1ad9b41b3605bd/macports-ports (master):

pdsh: Update to version 2.33

• Switch to GitHub
• Add genders variant
• Add new co-maintainer and GitHub handles
• Add missing dependency on ncurses

Closes: #57765
See: #53467

[mf2k (Frank Schima)]

Thanks for your patience everyone. I wanted to fix a few things before committing.