nghttp2 @1.36.0_0+python27 fails to build on OS X 10.11.6 (El Capitan)

[johnrosshunt]

nghttp2 1.36 fails to build on OS X 10.11.6 (El Capitan). XCode v8.2.1, clang-800.0.42.1

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2553:29: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'std::__1::unique_ptr<shrpx::HttpDownstreamConnection, std::__1::default_delete<shrpx::HttpDownstreamConnection> >' to 'const std::__1::unique_ptr<shrpx::DownstreamConnection, std::__1::default_delete<shrpx::DownstreamConnection> > &' for 1st argument
class _LIBCPP_TYPE_VIS_ONLY unique_ptr
                            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2582:49: note: candidate constructor not viable: no known conversion from 'std::__1::unique_ptr<shrpx::HttpDownstreamConnection, std::__1::default_delete<shrpx::HttpDownstreamConnection> >' to 'nullptr_t' for 1st argument
    _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR unique_ptr(nullptr_t) _NOEXCEPT
                                                ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2609:31: note: candidate constructor not viable: no known conversion from 'std::__1::unique_ptr<shrpx::HttpDownstreamConnection, std::__1::default_delete<shrpx::HttpDownstreamConnection> >' to 'std::__1::unique_ptr<shrpx::DownstreamConnection, std::__1::default_delete<shrpx::DownstreamConnection> > &&' for 1st argument
    _LIBCPP_INLINE_VISIBILITY unique_ptr(unique_ptr&& __u) _NOEXCEPT
                              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2613:9: note: candidate constructor [with _Up = shrpx::HttpDownstreamConnection, _Ep = std::__1::default_delete<shrpx::HttpDownstreamConnection>] not viable: no known conversion from 'std::__1::unique_ptr<shrpx::HttpDownstreamConnection, std::__1::default_delete<shrpx::HttpDownstreamConnection> >' to 'unique_ptr<shrpx::HttpDownstreamConnection, std::__1::default_delete<shrpx::HttpDownstreamConnection> > &&' for 1st argument
        unique_ptr(unique_ptr<_Up, _Ep>&& __u,
        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2628:35: note: candidate template ignored: could not match 'auto_ptr' against 'unique_ptr'
        _LIBCPP_INLINE_VISIBILITY unique_ptr(auto_ptr<_Up>&& __p,
                                  ^
1 error generated.
make[3]: *** [libnghttpx_a-shrpx_client_handler.o] Error 1
make[3]: *** Waiting for unfinished jobs....
mv -f .deps/libnghttpx_a-shrpx_http2_upstream.Tpo .deps/libnghttpx_a-shrpx_http2_upstream.Po
mv -f .deps/libnghttpx_a-shrpx_https_upstream.Tpo .deps/libnghttpx_a-shrpx_https_upstream.Po
mv -f .deps/libnghttpx_a-shrpx_config.Tpo .deps/libnghttpx_a-shrpx_config.Po
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_www_nghttp2/nghttp2/work/nghttp2-1.36.0/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_www_nghttp2/nghttp2/work/nghttp2-1.36.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_www_nghttp2/nghttp2/work/nghttp2-1.36.0'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_www_nghttp2/nghttp2/work/nghttp2-1.36.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_www_nghttp2/nghttp2/work/nghttp2-1.36.0" && /usr/bin/make -j4 -w all 
Exit code: 2
Error: Failed to build nghttp2: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_www_nghttp2/nghttp2/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.

[johnrosshunt]

main.log

[Schamschula (Marius Schamschula)]

Apparently a clang bug: See ​https://stackoverflow.com/questions/36752678/clang-returning-stdunique-ptr-with-type-conversion

[Schamschula (Marius Schamschula)]

I currently don't have an El Capitan system to test on.

[mf2k (Frank Schima)]

@Schamschula: If you submit a PR, Travis should try building it on El Capitan.

[Schamschula (Marius Schamschula)]

Before I put together a PR I want to know what is really going on. Having Travis rebuild numerous times for all OS versions makes no sense to me (as I'm still in the dark as what clang versions are at fault).

[Schamschula (Marius Schamschula)]

I've got a machine running Yosemite, but MacPorts was badly out of date. I'm in the process of updating all packages on that machine. Once it is done, I'll attempt to build nghttp2 there.

[Schamschula (Marius Schamschula)]

In 54d83cca9fc0f2ed6d3f873282b6dd3198635891/macports-ports (master):

nghttp2: fix clang C++11 vs C++14 confusion

See: ​https://stackoverflow.com/questions/32742741/clang-error-with-stdunique-ptr
Closes: #57960