Opened 5 years ago

Closed 3 years ago

#58029 closed update (fixed)

vtk: Update to 8.2.0

Reported by: luzpaz Owned by: stromnov (Andrey Stromnov)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: snarkhunter (Steve Langer)
Port: vtk

Description

Attachments (2)

Portfile-vtk-8.2.0 (6.2 KB) - added by snarkhunter (Steve Langer) 5 years ago.
proposed Portfile for vtk 8.2.0
patch-vtk82.diff (1.7 KB) - added by snarkhunter (Steve Langer) 5 years ago.
diff that upgrades Portfile for vtk 8.2.0

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by mf2k (Frank Schima)

Owner: set to stromnov
Port: vtk added; https://github.com/macports/macports-ports/blob/master/graphics/vtk removed
Status: newassigned

In the future, please add the port maintainer(s) to Cc (port info --maintainers vtk), if any.

comment:2 Changed 5 years ago by snarkhunter (Steve Langer)

Cc: snarkhunter added

Changed 5 years ago by snarkhunter (Steve Langer)

Attachment: Portfile-vtk-8.2.0 added

proposed Portfile for vtk 8.2.0

comment:3 Changed 5 years ago by snarkhunter (Steve Langer)

vtk 8.2.0 fixes bugs that I care about in 8.1.2, so please do upgrade.

I tried building 8.2.0. with the Portfile from 8.1.2, but had to make some modifications to get it to work. I've attached the modified file, which works for me, but I don't really know if the changes that I made are correct. I just added dependencies and config arguments until the compiler stopped complaining.

-- Steve

comment:4 Changed 5 years ago by mf2k (Frank Schima)

Thanks. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. Or better yet, submit a pull request.

Changed 5 years ago by snarkhunter (Steve Langer)

Attachment: patch-vtk82.diff added

diff that upgrades Portfile for vtk 8.2.0

comment:5 Changed 5 years ago by snarkhunter (Steve Langer)

I added the diff. I hope I did it correctly.

I believe that the existing patch in files/patch-python37.diff needs to be updated, but since I'm not using any of the pythonxx variants of vtk I have no way of testing it, and didn't try fixing it.

comment:6 Changed 5 years ago by mf2k (Frank Schima)

Thank you. A few comments:

  • You have added eigen3 as a dependency, can eigen3-devel also work? If so, you need to use a path reference. Like this:

path:include/eigen3/Eigen/Eigen:eigen3

  • Please sort all of the depenencies.

comment:7 Changed 5 years ago by snarkhunter (Steve Langer)

eigen3-devel appears to work. I don't know how to run the vtk test suite on the macports build, but it compiles without error and I run my vtk-based application.

comment:8 Changed 4 years ago by jjstickel (Jonathan Stickel)

Last edited 4 years ago by jjstickel (Jonathan Stickel) (previous) (diff)

comment:9 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.