Gimp 2.10.8 patches for Leopard and SnowLeopard to enable +quartz variant

[rmottola (Riccardo)]

I got gimp 2.10.8 working on Leopard 10.5 and Snow Leopard 10.6 in Quartz!

I have requested the patches to be accepted upstream, but there is no gaurantee that the next version will work or need more patches. This one appears to work very well. So for I share them here, could be useful and may be integrated.

To get full access, current gtk and gegl need patches too!

[kencu (Ken)]

I’m using the X11 variant as is on MacPorts. Please let me know what kind of gtk patches you are finding necessary.

[dbevans (David B. Evans)]

I'm not sure this is something we want to do on our own since this is an issue with GIMP itself, not a packaging issue. Best to push the idea upstream. Can you provide a pointer to your upstream submissions so we can track any progress there?

[rmottola (Riccardo)]

Ok - some were accepted, in the meanwhile 2.10.10 needs some new patches and has other issues.

​https://gitlab.gnome.org/GNOME/gimp/issues/2924

[rmottola (Riccardo)]

Most stuff was accepted upstream for gimp2 (but not gtk and gegl..). Besides Portifle issues, 2.10.10 needs only one new single patch to compile, pretty trivial.

[rmottola (Riccardo)]

new patch for 2.10.10

[mascguy (Christopher Nielsen)]

Riccardo, is a patch still needed for the latest GIMP release, when attempting to install the quartz variant on 10.5 and 10.6? (Assuming the latest release even builds for you on those MacOS releases...?)

[mascguy (Christopher Nielsen)]

Riccardo, are there any remaining patches that weren't added by us, and/or accepted by upstream?

[rmottola (Riccardo)]

I Did not check in the past month - patches inserted do not match 1:1 the one provided. I currently did not rebuild on 10.5 to fear I got an inconsistent system, maybe it is best to discuss this on the mailing list.

[rmottola (Riccardo)]

2.10.34 - disable update code

[rmottola (Riccardo)]

for 2.10.34 a new patch is needed, disables the update code, covered anyway my port updates. Tested only on 10.7, I am still struggling updating dependencies on 10.5 and 10.6 (force an update on the same version, asked on the mailing list)

[mascguy (Christopher Nielsen)]

Replying to rmottola:

for 2.10.34 a new patch is needed, disables the update code, covered anyway my port updates. Tested only on 10.7, I am still struggling updating dependencies on 10.5 and 10.6 (force an update on the same version, asked on the mailing list)

The update patch was recently applied to gimp2, along with other Quartz-related patches for gtk3. Details tracked by issue:67408

Is there anything else we're missing at this point?

[rmottola (Riccardo)]

I need a new patch, discovered today, on 10.6. It allows good build, I did not test for regression on newer versions though. Testing is also limited, since I still suffer from ​https://trac.macports.org/ticket/65897 so no text display, I tried functions randomly knowing button positions and things look fine.

Attached.

[rmottola (Riccardo)]

new for 2.10.34

[mascguy (Christopher Nielsen)]

Replying to rmottola:

I need a new patch, discovered today, on 10.6. It allows good build, I did not test for regression on newer versions though. Testing is also limited, since I still suffer from ​https://trac.macports.org/ticket/65897 so no text display, I tried functions randomly knowing button positions and things look fine.

Attached.

The patch is rather incomplete, there isn't even a filename, so I have no idea where it applies:

168a169
> #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1070
172a174
> #endif

Can you provide a real patch, generated via diff --unified?

[mascguy (Christopher Nielsen)]

Replying to rmottola:

I need a new patch, discovered today, on 10.6. It allows good build, I did not test for regression on newer versions though. Testing is also limited, since I still suffer from ​https://trac.macports.org/ticket/65897 so no text display, I tried functions randomly knowing button positions and things look fine.

Attached.

Okay, digging through the sources - and checking the logic on the lines in question - it looks like you're trying to disable display scaling support for 10.6 and earlier.

Currently testing with that patch for 10.6. Stay tuned...

[mascguy (Christopher Nielsen)]

This is the first time I've tried to build gtk3 +quartz for 10.6, and I'm seeing the following build errors:

:info:build ../gtk+-3.24.37/gdk/quartz/GdkQuartzView.c:409:10: error: initializing 'CGRect' (aka 'struct CGRect') with an expression of incompatible type 'id'
:info:build ../gtk+-3.24.37/gdk/quartz/GdkQuartzNSWindow.c:405:12: error: initializing 'NSRect' (aka 'struct CGRect') with an expression of incompatible type 'id'
:info:build ../gtk+-3.24.37/gdk/quartz/GdkQuartzNSWindow.c:422:12: error: initializing 'NSRect' (aka 'struct CGRect') with an expression of incompatible type 'id'
:info:build ../gtk+-3.24.37/gdk/quartz/gdkglcontext-quartz.c:111:7: error: use of undeclared identifier 'NSOpenGLPFAOpenGLProfile'
:info:build ../gtk+-3.24.37/gdk/quartz/gdkglcontext-quartz.c:111:33: error: use of undeclared identifier 'NSOpenGLProfileVersion3_2Core'

Presumably you've patched this too...? If so, can you attach that to this ticket, and I'll add it officially.