#58287 closed defect (fixed)

nghttp2 should have non-python variant

Reported by: vitalyster Owned by: Schamschula (Marius Schamschula)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: nghttp2

Description

Unable to open port: You must select one of the python variants

I don't need any python variant. Please allow it without monkey patching port file

Change History (10)

comment:1 Changed 19 months ago by vitalyster

Port: nghttp2 added

comment:2 Changed 19 months ago by Schamschula (Marius Schamschula)

Owner: set to Schamschula
Status: newassigned

I'll have a look.

comment:3 Changed 19 months ago by Schamschula (Marius Schamschula)

There seems to be an upstream issue, because --disable-python-bindings should prevent building the python bindings.

Even so, if I disable all versions of MacPorts Python, the configure script will look for and use Apple's Python version 2.7.

comment:4 Changed 19 months ago by Schamschula (Marius Schamschula)

Worse yet, it finds pieces of MacPorts python

checking for a Python interpreter with version >= 2.7... python
checking for python... /usr/bin/python
checking for python version... 2.7
checking for python platform... darwin
checking for python script directory... ${prefix}/lib/python2.7/site-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.7/site-packages

even though I'm configuring in trace mode.

comment:5 Changed 19 months ago by vitalyster

It looks like it's only find python on configuration stage, but does not build after

comment:6 Changed 19 months ago by vitalyster

diff --git a/configure.ac b/configure.ac
index 051eb139..e2a00ac8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -151,8 +151,6 @@ AC_PROG_MKDIR_P
 
 PKG_PROG_PKG_CONFIG([0.20])
 
-AM_PATH_PYTHON([2.7],, [:])
-
 if [test "x$request_lib_only" = "xyes"]; then
   request_app=no
   request_hpack_tools=no
@@ -161,6 +159,7 @@ if [test "x$request_lib_only" = "xyes"]; then
 fi
 
 if [test "x$request_python_bindings" != "xno"]; then
+  AM_PATH_PYTHON([2.7],, [:])
   AX_PYTHON_DEVEL([>= '2.7'])
 fi
 

this patch skips python detection :)

comment:7 Changed 19 months ago by Schamschula (Marius Schamschula)

The patch made no difference.

However, you a right, the python bindings are not built.

comment:8 Changed 19 months ago by vitalyster

obviously, configure script needs to be regenerated after patch, "autoreconf -if" do the right thing

comment:9 Changed 19 months ago by Schamschula (Marius Schamschula)

I didn't read the patch file too closely and missed the .ac extension...

I've rewritten the Portfile. I'll upload it this afternoon.

comment:10 Changed 19 months ago by Schamschula (Marius Schamschula)

Resolution: fixed
Status: assignedclosed

In 484b0e9201ce6934c95fcbfb7767c27fe7f89c32/macports-ports (master):

nghttp2: permit build w/o python

Closes: #58287
remove traces of python34

Note: See TracTickets for help on using tickets.