Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#58352 closed defect (fixed)

wireshark ports: depends on incorrect qt5 version on older OS versions

Reported by: dzhub Owned by: ghosthound
Priority: Normal Milestone:
Component: ports Version: 2.5.4
Keywords: haspatch Cc:
Port: wireshark3 wireshark2 wireshark22 wireshark24

Description

Hi there,

today I tried to install Wireshark3 on a Mac running macOS 10.11.6 (2,8 GHz Quad-Core Intel Xeon). Is there something I can do about this:

--->  Fetching archive for qt5-qtbase
--->  Attempting to fetch qt5-qtbase-5.12.2_0+openssl.darwin_15.x86_64.tbz2 from https://packages.macports.org/qt5-qtbase
--->  Attempting to fetch qt5-qtbase-5.12.2_0+openssl.darwin_15.x86_64.tbz2 from http://lil.fr.packages.macports.org/qt5-qtbase
--->  Attempting to fetch qt5-qtbase-5.12.2_0+openssl.darwin_15.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/qt5-qtbase
--->  Fetching distfiles for qt5-qtbase
Error: qt5-qtbase requires macOS 10.12 or later
Error: Failed to fetch qt5-qtbase: incompatible OS version
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_aqua_qt5/qt5-qtbase/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port wireshark3 failed

Thank you for any hints.

Attachments (2)

main.log (2.1 KB) - added by dzhub 18 months ago.
Portfile.diff (770 bytes) - added by jmroot (Joshua Root) 18 months ago.

Download all attachments as: .zip

Change History (10)

Changed 18 months ago by dzhub

Attachment: main.log added

comment:1 Changed 18 months ago by jmroot (Joshua Root)

Keywords: qt5-qtbase requires macOS 10.12 or later removed
Owner: set to ghosthound
Port: wireshark3 added
Status: newassigned
Summary: macOS 10.11.6: Error: Processing of port wireshark3 failed/ qt5-qtbase requires macOS 10.12 or laterwireshark3: depends on incorrect qt5 version on older OS versions

From what I understand, ports using Qt 5 are expected to use the qt5 portgroup in order to depend on the correct version based on the OS version (e.g. qt511-* on 10.11).

Changed 18 months ago by jmroot (Joshua Root)

Attachment: Portfile.diff added

comment:2 Changed 18 months ago by jmroot (Joshua Root)

Keywords: haspatch added

comment:3 Changed 18 months ago by jmroot (Joshua Root)

Port: wireshark2 wireshark22 wireshark24 added
Summary: wireshark3: depends on incorrect qt5 version on older OS versionswireshark ports: depends on incorrect qt5 version on older OS versions

This actually applies to most of the wireshark ports.

comment:4 Changed 18 months ago by ghosthound

The wireshark ports do use "PortGroup qt5 1.0" - see the qt5 variant. What might be incorrect is the use of "depends_lib-append" for qt5 components, I'll look at changing those over to use "qt5.depends_component"

comment:5 Changed 18 months ago by jmroot (Joshua Root)

Right, the portgroup is included but not used to declare the qt5-* dependencies. The patch I attached seems to change the deps correctly with an older os.major.

comment:6 Changed 18 months ago by cjones051073 (Chris Jones)

I actually committed fixes for this yesterday. E.g.

[52d63c0d74622e1564ac52401e8c6c47912b2538/macports-ports]

Apologies for bypassing trac, but I failed to notice this ticket, and as it was a clear bug fix to currently broken platforms, I thought it acceptable to commit directly. Apologies if you disagree.

As a side comment, unless you really strongly object, please consider making the wireshark ports openmaintainer. We tend to prefer this, unless there are good reasons not to.

Last edited 18 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:7 Changed 18 months ago by cjones051073 (Chris Jones)

Resolution: fixed
Status: assignedclosed

comment:8 in reply to:  6 Changed 18 months ago by ghosthound

Replying to cjones051073:

I actually committed fixes for this yesterday. E.g.

[52d63c0d74622e1564ac52401e8c6c47912b2538/macports-ports]

Apologies for bypassing trac, but I failed to notice this ticket, and as it was a clear bug fix to currently broken platforms, I thought it acceptable to commit directly. Apologies if you disagree.

As a side comment, unless you really strongly object, please consider making the wireshark ports openmaintainer. We tend to prefer this, unless there are good reasons not to.

Please don't make commits against ports that are not (no|open)maintainer.

Note: See TracTickets for help on using tickets.