kde4-kile fails to build on Mojave

[gregyao]

Mojave 10.14.4 MacBook Pro, Mid 2014, i7

:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_kde4-kile/kde4-kile/work/kile-2.1.3/src/eventfilter.cpp:25:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/Document:1:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/../../ktexteditor/document.h:26:
:info:build /opt/local/include/KDE4/ktexteditor/cursor.h:309:12: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
:info:build       if (&cursor)
:info:build       ~~   ^~~~~~
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_kde4-kile/kde4-kile/work/kile-2.1.3/src/eventfilter.cpp:25:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/Document:1:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/../../ktexteditor/document.h:27:
:info:build /opt/local/include/KDE4/ktexteditor/range.h:572:12: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
:info:build       if (&range)
:info:build       ~~   ^~~~~
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_kde4-kile/kde4-kile/work/kile-2.1.3/src/kileerrorhandler.cpp:25:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/Document:1:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/../../ktexteditor/document.h:26:
:info:build /opt/local/include/KDE4/ktexteditor/cursor.h:309:12: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
:info:build       if (&cursor)
:info:build       ~~   ^~~~~~
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_kde4-kile/kde4-kile/work/kile-2.1.3/src/kileerrorhandler.cpp:25:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/Document:1:
:info:build In file included from /opt/local/include/KDE4/KDE/KTextEditor/../../ktexteditor/document.h:27:
:info:build /opt/local/include/KDE4/ktexteditor/range.h:572:12: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
:info:build       if (&range)
:info:build       ~~   ^~~~~

--Stuff Deleted--

:info:build Exit code: 2
:error:build Failed to build kde4-kile: command execution failed
:debug:build Error code: CHILDSTATUS 5168 2
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "system {*}$notty {*}$nice $fullcmdstring"
:debug:build     invoked from within
:debug:build "command_exec build"
:debug:build     (procedure "portbuild::build_main" line 8)
:debug:build     invoked from within
:debug:build "$procedure $targetname"
:error:build See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_kde4-kile/kde4-kile/main.log for details.

[gregyao]

Error log:

[jmroot (Joshua Root)]

The actual error appears to be:

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_kde4-kile/kde4-kile/work/kile-2.1.3/src/editorkeysequencemanager.cpp:206:51: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build                         if(m_watchedKeySequencesList.contains(toCheck) > 0) {
:info:build                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

[NicosPavlov]

Yes, several KDE ports have had such issues in the past weeks, thanks for the pointer.

[Nicolas Pavillon <pavillon.nicolas@…>]

In 5a5682478dcd9be132040ccaf60622c31377c1d3/macports-ports (master):

kde4-kile: Fix build on 10.14. Fixes #58435.