krusader @2.4.0-beta3_2: error: ordered comparison between pointer and zero ('const void *' and 'int')

[Andrew-McGee (Andrew McGee)]

MacOS 10.14.4 - MacBook Pro 2017.

This seems to be a frequent error, popping up in various ports, with later versions of Clang throwing an error like this one reported here: ticket:58354

krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp 
error: ordered comparison between pointer and zero ('const void *' and 'int')

See attached logfile.

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:67:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar")) typeData->addItem("tar");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:68:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("gzip")) typeData->addItem("tar.gz");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:68:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("gzip")) typeData->addItem("tar.gz");
:info:build                      ^~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:69:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("bzip2")) typeData->addItem("tar.bz2");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:69:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("bzip2")) typeData->addItem("tar.bz2");
:info:build                      ^~~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:70:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("lzma")) typeData->addItem("tar.lzma");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:70:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("lzma")) typeData->addItem("tar.lzma");
:info:build                      ^~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:71:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("xz")) typeData->addItem("tar.xz");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:71:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("xz")) typeData->addItem("tar.xz");
:info:build                      ^~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:72:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("zip")) typeData->addItem("zip");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:73:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("rar")) typeData->addItem("rar");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:74:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("lha")) typeData->addItem("lha");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:75:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("arj")) typeData->addItem("arj");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:76:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("7z")) typeData->addItem("7z");
:info:build         ^~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build 14 errors generated.}}

[Andrew-McGee (Andrew McGee)]

main.log

[SoleSS (Michael Nordheimer)]

patches to fix building: ​https://svnweb.freebsd.org/ports?view=revision&revision=478438

[delphym (DelphyM)]

Replying to SoleSS:

patches to fix building: ​https://svnweb.freebsd.org/ports?view=revision&revision=478438

Hi there, I have same problem on a little bit newer (say up-to-date) macOS: 10.14.6 and MacPort: 2.6.2

The log content seems pretty similar.

I can see there has been a patch provided. Any chance @SoleSS could provide instructions how to apply this patch for users who can do basic MacPorts management and can do SCM operations, but are not linux developers? Many thanks in advance.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #65444.

[ryandesign (Ryan Carsten Schmidt)]

The patch works for me. I'll commit it shortly.

[ryandesign (Ryan Carsten Schmidt)]

In 10e3962f43fce7f6a0dfcaff90e3c7aae2d41436/macports-ports (master):

krusader: Fix ordered comparison between pointer and zero

Closes: #58459