Opened 3 years ago

Closed 3 months ago

#58459 closed defect (fixed)

krusader @2.4.0-beta3_2: error: ordered comparison between pointer and zero ('const void *' and 'int')

Reported by: Andrew-McGee (Andrew McGee) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.5.4
Keywords: Cc: osmobco
Port: krusader

Description (last modified by mf2k (Frank Schima))

MacOS 10.14.4 - MacBook Pro 2017.

This seems to be a frequent error, popping up in various ports, with later versions of Clang throwing an error like this one reported here: ticket:58354

krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp 
error: ordered comparison between pointer and zero ('const void *' and 'int')

See attached logfile.

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:67:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar")) typeData->addItem("tar");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:68:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("gzip")) typeData->addItem("tar.gz");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:68:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("gzip")) typeData->addItem("tar.gz");
:info:build                      ^~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:69:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("bzip2")) typeData->addItem("tar.bz2");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:69:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("bzip2")) typeData->addItem("tar.bz2");
:info:build                      ^~~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:70:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("lzma")) typeData->addItem("tar.lzma");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:70:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("lzma")) typeData->addItem("tar.lzma");
:info:build                      ^~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:71:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("xz")) typeData->addItem("tar.xz");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:71:22: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("tar") && PS("xz")) typeData->addItem("tar.xz");
:info:build                      ^~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:72:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("zip")) typeData->addItem("zip");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:73:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("rar")) typeData->addItem("rar");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:74:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("lha")) typeData->addItem("lha");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:75:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("arj")) typeData->addItem("arj");
:info:build         ^~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:76:9: error: ordered comparison between pointer and zero ('const void *' and 'int')
:info:build     if (PS("7z")) typeData->addItem("7z");
:info:build         ^~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_kde_krusader/krusader/work/krusader-2.4.0-beta3/krusader/Dialogs/packgui.cpp:43:30: note: expanded from macro 'PS'
:info:build #define PS(x) lst.contains(x)>0
:info:build               ~~~~~~~~~~~~~~~^~
:info:build 14 errors generated.}}

Attachments (1)

main.log (1.2 MB) - added by Andrew-McGee (Andrew McGee) 3 years ago.
main.log

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by Andrew-McGee (Andrew McGee)

Attachment: main.log added

main.log

comment:1 Changed 3 years ago by jmroot (Joshua Root)

Keywords: Krusader Clang removed
Owner: set to kurthindenburg
Status: newassigned

comment:2 Changed 3 years ago by mf2k (Frank Schima)

Port: krusader added; Krusader removed

comment:3 Changed 3 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:4 Changed 3 years ago by SoleSS (Michael Nordheimer)

comment:5 Changed 2 years ago by delphym (DelphyM)

Last edited 2 years ago by delphym (DelphyM) (previous) (diff)

comment:6 in reply to:  4 Changed 2 years ago by delphym (DelphyM)

Replying to SoleSS:

patches to fix building: https://svnweb.freebsd.org/ports?view=revision&revision=478438

Hi there, I have same problem on a little bit newer (say up-to-date) macOS: 10.14.6 and MacPort: 2.6.2

The log content seems pretty similar.

I can see there has been a patch provided. Any chance @SoleSS could provide instructions how to apply this patch for users who can do basic MacPorts management and can do SCM operations, but are not linux developers? Many thanks in advance.

comment:7 Changed 3 months ago by ryandesign (Ryan Schmidt)

Cc: osmobco added
Summary: Krusader Fails to Build on Mojavekrusader @2.4.0-beta3_2: error: ordered comparison between pointer and zero ('const void *' and 'int')

Has duplicate #65444.

comment:8 Changed 3 months ago by ryandesign (Ryan Schmidt)

Owner: changed from kurthindenburg to ryandesign
Status: assignedaccepted

The patch works for me. I'll commit it shortly.

comment:9 Changed 3 months ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: acceptedclosed

In 10e3962f43fce7f6a0dfcaff90e3c7aae2d41436/macports-ports (master):

krusader: Fix ordered comparison between pointer and zero

Closes: #58459

Note: See TracTickets for help on using tickets.