pypy @7.1.1: didn't catch all references to /sw and /opt/local

[ryandesign (Ryan Carsten Schmidt)]

​Build fails:

DEBUG: Executing proc-post-org.macports.patch-patch-0
Error: Failed to patch pypy: didn't catch all references to /sw and /opt/local:
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_pypy/pypy/work/pypy2.7-v7.1.1-src/pypy/doc/image/bpnn_update_detail.png
DEBUG: Error code: NONE

[jmroot (Joshua Root)]

How could a PNG image possibly contain a relevant path reference? At worst it's just in the metadata, and it could easily just be /sw coincidentally occurring somewhere in the binary data.

[ryandesign (Ryan Carsten Schmidt)]

Yes. The point is, the build failed, so maybe that check needs to be refined to only check text files.

[jmroot (Joshua Root)]

In aa585153068a6336839c106cd2004f603913ed4d/macports-ports (master):

pypy: don't abort when '/sw' is in a binary file

See: #58532

[jmroot (Joshua Root)]

I changed it to a warning for now, just to fix the build failure. I'll leave further refinements to the maintainer, such as restricting the check to appropriate file types, and a maintainer mode variable that can be set to turn the warning into an error.

[ryandesign (Ryan Carsten Schmidt)]

Ping

[danchr (Dan Villiom Podlaski Christiansen)]

In a2875252600ac2b443dc3f0a1a98d043a11ed51c/macports-ports (master):

pypy: bump to 7.2.0

While at it, I restricted the check for hardcoded paths to text files,
which should fix ​https://github.com/macports/macports-ports/pull/58532.

Closes: #58532