#58664 closed defect (fixed)

aria2 @1.34.0: error: use of undeclared identifier 'make_unique'

Reported by: ryandesign (Ryan Schmidt) Owned by: Schamschula (Marius Schamschula)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: aria2

Description

aria2 doesn't build:

In file included from InternalDHKeyExchange.cc:36:
In file included from ./InternalDHKeyExchange.h:40:
./bignum.h:34:25: error: use of undeclared identifier 'make_unique'
  inline ulong() : buf_(make_unique<char_t[]>(dim)) {}
                        ^
./bignum.h:34:37: error: unexpected type name 'char_t': expected expression
  inline ulong() : buf_(make_unique<char_t[]>(dim)) {}
                                    ^
./bignum.h:34:44: error: expected expression
  inline ulong() : buf_(make_unique<char_t[]>(dim)) {}
                                           ^
./bignum.h:35:33: error: use of undeclared identifier 'make_unique'
  inline ulong(size_t t) : buf_(make_unique<char_t[]>(dim))
                                ^
./bignum.h:35:45: error: unexpected type name 'char_t': expected expression
  inline ulong(size_t t) : buf_(make_unique<char_t[]>(dim))
                                            ^
./bignum.h:35:52: error: expected expression
  inline ulong(size_t t) : buf_(make_unique<char_t[]>(dim))
                                                   ^
./bignum.h:39:46: error: use of undeclared identifier 'make_unique'
  inline ulong(const ulong<dim>& rhs) : buf_(make_unique<char_t[]>(dim))
                                             ^
./bignum.h:39:58: error: unexpected type name 'char_t': expected expression
  inline ulong(const ulong<dim>& rhs) : buf_(make_unique<char_t[]>(dim))
                                                         ^
./bignum.h:39:65: error: expected expression
  inline ulong(const ulong<dim>& rhs) : buf_(make_unique<char_t[]>(dim))
                                                                ^
./bignum.h:44:14: error: use of undeclared identifier 'make_unique'
      : buf_(make_unique<char_t[]>(dim))
             ^
./bignum.h:44:26: error: unexpected type name 'char_t': expected expression
      : buf_(make_unique<char_t[]>(dim))
                         ^
./bignum.h:44:33: error: expected expression
      : buf_(make_unique<char_t[]>(dim))
                                ^

Change History (2)

comment:1 Changed 16 months ago by Schamschula (Marius Schamschula)

It looks like we now need C++14.

Unfortunately, the cxx11 PortGroup is of no help here.

I didn't run into this issue, as I build aria2 +gnutls +sqlite3, now also with +cares.

comment:2 Changed 16 months ago by Schamschula (Marius Schamschula)

Resolution: fixed
Status: assignedclosed

In ce9cf2d12d0012144c6bf57e5b758508acec4de0/macports-ports (master):

aria2: non-gnutls variants need C++14

Closes: #58664

Note: See TracTickets for help on using tickets.