Opened 5 years ago

Closed 5 years ago

#58867 closed defect (fixed)

bazel*: rename variant to bash_completion

Reported by: blair (Blair Zajac) Owned by: blair (Blair Zajac)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: bazel

Description

It appears that bash_completion is the more standard name: 

$ git grep 'variant bash_completion'
devel/bzr/Portfile:variant bash_completion {
devel/carthage/Portfile:variant bash_completion {
devel/docker-machine/Portfile:variant bash_completion {
devel/docker/Portfile:variant bash_completion {
devel/google-cloud-sdk/Portfile:variant bash_completion {
devel/mercurial/Portfile:variant bash_completion {
devel/redo/Portfile:variant bash_completion {
java/spring-boot-cli/Portfile:variant bash_completion {
python/py-django/Portfile:    variant bash_completion {
www/doctl/Portfile:variant bash_completion {
www/hugo/Portfile:variant bash_completion {

Versus 

$ git grep 'variant bash '
devel/bazel/Portfile:variant bash description {Enable bash completion support} {
security/pass/Portfile:variant bash description {Include Bash completion support} {

Please consider renaming the variant.

Change History (6)

comment:1 Changed 5 years ago by blair (Blair Zajac)

Owner: changed from RootFunction to cjones051073

comment:2 Changed 5 years ago by cjones051073 (Chris Jones)

Seems reasonable. GitHub PRs implementing the change gratefully accepted...

comment:3 Changed 5 years ago by blair (Blair Zajac)

I can do a commit myself, I have committer rights. I'll just do s/bash/bash_completion/g and bump the revision. Does that sound fine?

comment:4 Changed 5 years ago by cjones051073 (Chris Jones)

yep fine by me.

comment:5 Changed 5 years ago by blair (Blair Zajac)

Owner: changed from cjones051073 to blair
Status: assigned → accepted

comment:6 Changed 5 years ago by blair (Blair Zajac)

Resolution: → fixed
Status: accepted → closed

In 7d65789380e65f134ef6e6173e723394b9305504/macports-ports (master):

bazel: rename bash variant to bash_completion.

Delete the description because it is provided by variant_descriptions.conf.

Closes: #58867

Note: See TracTickets for help on using tickets.