Opened 5 years ago

Closed 4 years ago

#58950 closed defect (fixed)

lirc @0.9.4d_4: docs won't build on < 10.7 due to TypeError: 'str' object does not support item assignment

Reported by: kencu (Ken) Owned by: ctreleaven (Craig Treleaven)
Priority: Normal Milestone:
Component: ports Version:
Keywords: snowleopard Cc:
Port: lirc

Description

test -e lirc || ln -s ../tools/lirc-setup lirc || :
PYTHONPATH=.:../tools \
	/opt/local/bin/python3.6 ./data2table ../configs ../configs \
	        | xsltproc --html docpage.xsl - > table.html
test -e lirc || ln -s ../tools/lirc-setup lirc || :
PYTHONPATH=.:../tools \
	/opt/local/bin/python3.6 ./data2hwdb ../configs ../configs \
	    > lirc.hwdb
xsltproc --html docpage.xsl \
	    $(echo ./html/api-general.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/api-general.html
xsltproc --html docpage.xsl \
	    $(echo ./html/configuration-guide.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/configuration-guide.html
/opt/local/bin/gsed -i -e "s/@version@/0.9.4d/" html/api-general.html
/opt/local/bin/gsed -i -e "s/@version@/0.9.4d/" html/configuration-guide.html
xsltproc --html docpage.xsl \
	    $(echo ./html/configure.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/configure.html
xsltproc --html docpage.xsl \
	    $(echo ./html/driver-api.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/driver-api.html
/opt/local/bin/gsed -i -e "s/@version@/0.9.4d/" html/configure.html
Traceback (most recent call last):
  File "./data2table", line 118, in <module>
    main()
  File "./data2table", line 101, in main
    db = database.Database(configdir, yamldir)
  File "/opt/local/var/macports/build/_opt_macports-ports_sysutils_lirc/lirc/work/lirc-0.9.4d/doc/lirc/database.py", line 124, in __init__
    d['id'] = key
TypeError: 'str' object does not support item assignment
-:1: HTML parser error : Document is empty

^
xsltproc --html docpage.xsl \
	    $(echo ./html/empty_toc.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/empty_toc.html
/opt/local/bin/gsed -i -e "s/@version@/0.9.4d/" html/driver-api.html
xsltproc --html docpage.xsl \
	    $(echo ./html/help.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/help.html
/opt/local/bin/gsed -i -e "s/@version@/0.9.4d/" html/empty_toc.html
xsltproc --html docpage.xsl \
	    $(echo ./html/index.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/index.html
/opt/local/bin/gsed -i -e "s/@version@/0.9.4d/" html/help.html
xsltproc --html docpage.xsl \
	    $(echo ./html/install.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/install.html
/opt/local/bin/gsed -i -e "s/@version@/0.9.4d/" html/index.html
xsltproc --html docpage.xsl \
	    $(echo ./html/lirc_client.html | /opt/local/bin/gsed 's|html/|html-source/|') > html/lirc_client.html
Traceback (most recent call last):
  File "./data2hwdb", line 110, in <module>
    main()
  File "./data2hwdb", line 98, in main
    db = database.Database(configdir, yamldir)
  File "/opt/local/var/macports/build/_opt_macports-ports_sysutils_lirc/lirc/work/lirc-0.9.4d/doc/lirc/database.py", line 124, in __init__
    d['id'] = key
TypeError: 'str' object does not support item assignment
make[2]: *** [lirc.hwdb] Error 1

disabling the docs by patching Makefile.am works to fix the build.

I haven't tried anything older than SnowLeopard as yet.

Attachments (1)

lirc-fail-SL.log (322.3 KB) - added by kencu (Ken) 5 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by kencu (Ken)

see: <https://github.com/macports/macports-ports/pull/5228>

I tried updating the lirc port to 0.10.1 but this didn't fix the above issue.

Changed 5 years ago by kencu (Ken)

Attachment: lirc-fail-SL.log added

comment:2 Changed 5 years ago by kencu (Ken)

Resolution: fixed
Status: assignedclosed

In 2b8f60eeba14c0f5f012cf68aefa818658d57374/macports-ports (master):

lirc: disable docs on < lion

closes: #58950

comment:3 Changed 5 years ago by kencu (Ken)

Resolution: fixed
Status: closedreopened

The patch I pushed through to disable the docs on < 10.7 does work to fix the build, but I'll reopen this as we should have a proper fix for the docs in the end.

Here's something a bit strange. If I get to the error point above, then open up the permissions in the build folder like this:

cd `port work lirc`
sudo chmod -R a+rw .

and then continue the build, it finishes properly.

Now why would that only be an issue on < 10.7?

comment:4 Changed 4 years ago by kencu (Ken)

Resolution: fixed
Status: reopenedclosed

this has been, in end, fixed for all practical purposes by disabling the document building, and I don't plan to come back to this to fix the building of the docs.

Note: See TracTickets for help on using tickets.