Opened 3 years ago

Closed 3 years ago

#59002 closed defect (fixed)

ipmitool: doesn't build after openssl update

Reported by: pioto (Mike Kelly) Owned by: drkp (Dan Ports)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: pioto (Mike Kelly), stuartthebruce
Port: ipmitool

Description

Seems there was some recent, incompatible update to openssl in MacPorts.

See the attached build log, which shows, in part:

:info:build lanplus_crypt_impl.c:158:17: error: variable has incomplete type 'EVP_CIPHER_CTX' (aka 'struct evp_cipher_ctx_st')
:info:build         EVP_CIPHER_CTX ctx;
:info:build                        ^
:info:build /opt/local/include/openssl/ossl_typ.h:90:16: note: forward declaration of 'struct evp_cipher_ctx_st'
:info:build typedef struct evp_cipher_ctx_st EVP_CIPHER_CTX;
:info:build                ^
:info:build lanplus_crypt_impl.c:233:17: error: variable has incomplete type 'EVP_CIPHER_CTX' (aka 'struct evp_cipher_ctx_st')
:info:build         EVP_CIPHER_CTX ctx;
:info:build                        ^
:info:build /opt/local/include/openssl/ossl_typ.h:90:16: note: forward declaration of 'struct evp_cipher_ctx_st'
:info:build typedef struct evp_cipher_ctx_st EVP_CIPHER_CTX;
:info:build                ^
:info:build 2 errors generated.
:info:build make[4]: *** [lanplus_crypt_impl.lo] Error 1
:info:build make[4]: *** Waiting for unfinished jobs....

Attachments (2)

main.log (94.3 KB) - added by pioto (Mike Kelly) 3 years ago.
Portfile (1.9 KB) - added by matthias-scheler (Matthias Scheler) 3 years ago.
New port file that fixes the build problem

Download all attachments as: .zip

Change History (12)

Changed 3 years ago by pioto (Mike Kelly)

Attachment: main.log added

comment:1 Changed 3 years ago by pioto (Mike Kelly)

Cc: pioto added

comment:2 Changed 3 years ago by mf2k (Frank Schima)

Owner: set to drkp
Status: newassigned

In the future, please add the port maintainer(s) to Cc (port info --maintainers ipmitool), if any.

comment:3 Changed 3 years ago by matthias-scheler (Matthias Scheler)

Even the latest upstream version doesn't support OpenSSL 1.1.x. The easiest fix would be to depend on "devel/openssl10" and invoke "configure" with appropriate arguments.

Changed 3 years ago by matthias-scheler (Matthias Scheler)

Attachment: Portfile added

New port file that fixes the build problem

comment:4 Changed 3 years ago by mf2k (Frank Schima)

Thanks. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. Or better yet, submit a pull request.

comment:5 Changed 3 years ago by kencu (Ken)

In this case, don't bother with the PR just yet.

There is an old_openssl PortGroup we'll try to use for this fix!

comment:6 Changed 3 years ago by yan12125 (Chih-Hsuan Yen)

comment:7 Changed 3 years ago by eborisch (Eric A. Borisch)

Unless there are objections, I'm planning to merge ​https://github.com/macports/macports-ports/pull/5317. This uses a pre-release version that (as opposed to the release) actually compiles. I've been able to run (mainly SOL) the new version of the compiled executable without issue.

comment:8 Changed 3 years ago by stuartthebruce

Cc: stuartthebruce added

comment:9 Changed 3 years ago by eborisch (Eric A. Borisch)

In 9867c3ff9e5a5fd4de69ec1d05bd99ad52100e6c/macports-ports (master):

ipmitool: Update to post-1.8.18

Update to a version compatible with openssl 1.1

See also this ticket suggesting using old_openssl instead:

#59002

comment:10 Changed 3 years ago by eborisch (Eric A. Borisch)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.