Opened 3 years ago

Closed 11 months ago

#59028 closed update (invalid)

inkscape-gtk3-devel has a beta release

Reported by: pietvo (Pieter van Oostrum) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cooljeanius (Eric Gallager)
Port: inkscape-gtk3-devel

Description

The inkscape repository recently released version 1.0beta.

I installed it, but it needed some changes. There was a reinplace that didn't work because it needed a variable where the Portfile had a constant 'lib'. I also added a dependency on gtk-osx-application-gtk3 as the install instructions on the inkscape repository suggests. This makes a better UX on MacOS (Command instead of Ctrl, standard MacOS menu structure). I have added the path for the Portfile.

Attachments (1)

patch (1.9 KB) - added by pietvo (Pieter van Oostrum) 3 years ago.
patch

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by pietvo (Pieter van Oostrum)

Attachment: patch added

patch

comment:1 Changed 3 years ago by mf2k (Frank Schima)

Cc: devans @… removed
Owner: set to dbevans
Status: newassigned

comment:2 Changed 3 years ago by mf2k (Frank Schima)

Thanks. Note that the revision gets set back to 0 when increasing the version. Also, submitting a pull request will get this committed much faster.

comment:3 Changed 3 years ago by pietvo (Pieter van Oostrum)

Ok, I forgot about the revision. And I didn't want to bypass the maintainer by submitting a pull request directly. If that's no problem I will do.

comment:4 Changed 3 years ago by mf2k (Frank Schima)

You are not bypassing the maintainer by submitting a PR. It is the preferred way to get changes in Macports. Maintainers don't normally do a PR and simply commit to the repository directly. So submitting PRs is precisely for someone like you who is interested in getting a port updated or fixed.

comment:5 Changed 3 years ago by kencu (Ken)

FYI, that gtk-osx-application-gtk3 business often needs special handling. See here for example:

[fd53e156016c9beddb42c4402ab45390ddef6f92/macports-ports]

Last edited 3 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:6 Changed 3 years ago by pietvo (Pieter van Oostrum)

Indeed, I was wondering if the gtk-osx-application-gtk3 dependency should be dependent on the quartz variant.

Or should the decision to install gtk-osx-application-gtk3 be left up to the user?

If you can give me an advice on this choice, I will submit a pull request.

comment:7 Changed 3 years ago by kencu (Ken)

Divid is the mainainer of this port, and will likely handle it like he did in the commit I refernced,

He won't likely upgrade the port to a beta just now, though...

As it's working for you, perhaps just leave this here as a request for now?

comment:8 Changed 3 years ago by rubendibattista (Ruben Di Battista)

Just as a reference, here I have my version of the Portfile: https://github.com/rubendibattista/macports-ports/tree/inkscape-gtk3. It builds and runs ok, but there's a bug on macOS that gives poor performances of Inkscape. Here the related issue.

There's also an apparently harmless problem with dbus connection: #59153

Last edited 3 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:9 Changed 11 months ago by cooljeanius (Eric Gallager)

Cc: cooljeanius added

comment:10 Changed 11 months ago by mascguy (Christopher Nielsen)

Resolution: invalid
Status: assignedclosed

This port is now obsolete; closing.

Note: See TracTickets for help on using tickets.