Opened 16 months ago

Closed 13 months ago

Last modified 13 months ago

#59158 closed defect (fixed)

libtorrent-rasterbar @1.2.2 fails to build on mavericks

Reported by: tehcog (tehcog) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.6.1
Keywords: Cc:
Port: libtorrent-rasterbar

Description

please see attached log file.

--->  Computing dependencies for libtorrent-rasterbar
--->  Fetching archive for libtorrent-rasterbar
--->  Attempting to fetch libtorrent-rasterbar-1.2.2_0+python27.darwin_13.x86_64.tbz2 from https://packages.macports.org/libtorrent-rasterbar
--->  Attempting to fetch libtorrent-rasterbar-1.2.2_0+python27.darwin_13.x86_64.tbz2 from http://ywg.ca.packages.macports.org/mirror/macports/packages/libtorrent-rasterbar
--->  Attempting to fetch libtorrent-rasterbar-1.2.2_0+python27.darwin_13.x86_64.tbz2 from http://aus.us.packages.macports.org/macports/packages/libtorrent-rasterbar
--->  Fetching distfiles for libtorrent-rasterbar
--->  Verifying checksums for libtorrent-rasterbar
--->  Extracting libtorrent-rasterbar
--->  Applying patches to libtorrent-rasterbar
--->  Configuring libtorrent-rasterbar
--->  Building libtorrent-rasterbar
Error: Failed to build libtorrent-rasterbar: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_libtorrent-rasterbar/libtorrent-rasterbar/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.

Attachments (1)

libtorrent-rasterbar_main.log (714.2 KB) - added by tehcog (tehcog) 16 months ago.
main.log

Download all attachments as: .zip

Change History (6)

Changed 16 months ago by tehcog (tehcog)

main.log

comment:1 Changed 16 months ago by ryandesign (Ryan Schmidt)

Cc: dbevans removed
Owner: set to dbevans
Status: newassigned

The first error I see in the log is:

error: unknown type name 'constexpr'

Brief searching leads me to understand this is a C++11 feature, so the fix may be as simple as adding -std=c++11 to configure.cxxflags (or probably better to use the new compiler.cxx_standard option introduced in MacPorts 2.6.0).

comment:2 Changed 16 months ago by ryandesign (Ryan Schmidt)

Trying to use it myself in another port, I'm realizing that apparently setting compiler.*_standard only helps you select a compatible compiler. It doesn't add the -std flag for you. You still have to do that separately.

comment:3 Changed 13 months ago by ryandesign (Ryan Schmidt)

In fact the port does use compiler.cxx_standard 2011. The attached log shows it using MacPorts clang++ 8 to build some earlier parts. But the build system then fails to use the requested compiler when "building 'libtorrent' extension", going back to using /usr/bin/clang, which of course fails. The compiler selection needs to be propagated to all parts of the build

comment:4 Changed 13 months ago by dbevans (David B. Evans)

Resolution: fixed
Status: assignedclosed

Fixed by updating to version 1.2.3 and explicitly adding -std=c++11 to configure.cxxflags. As @ryandesign has found out, compiler.cxx_standard doesn't do this for you, so the port failed with compilers that don't default to C++11. This includes Apple clang on 10.11 and earlier.

See https://github.com/macports/macports-ports/commit/8e9cef33d3ea55bb1250adbb3237c18b6a75f0f8

comment:5 Changed 13 months ago by kencu (Ken)

We talked about whether base should set that standard as part of setting the cxx_standard, and decided it should not do so, based on conflicts with other similar standards such as gnu++11 etc.

Note: See TracTickets for help on using tickets.