Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#59310 closed defect (fixed)

gnuradio-next +python34 depends on nonexistent ports

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version: 2.6.1
Keywords: Cc: dbevans (David B. Evans), jjstickel (Jonathan Stickel)
Port: gnuradio-next

Description

gnuradio-next +python34 depends on nonexistent ports py34-gobject3 and py34-pyqtgraph which do not exist.

Change History (10)

comment:1 Changed 5 years ago by jmroot (Joshua Root)

Cc: jjstickel dbevans added

They did exist but were removed in changeset:e15b868/macports-ports and changeset:cef2d42/macports-ports.

comment:2 Changed 5 years ago by jjstickel (Jonathan Stickel)

Obviously, the +python34 and +python35 variants should be removed from gnuradio-next.

comment:3 Changed 5 years ago by jjstickel (Jonathan Stickel)

Cc: jjstickel removed

comment:4 Changed 5 years ago by michaelld (Michael Dickens)

I agree with the +python34 removal.

When I look for the various +python35 dependencies they are all there for me ... but the commit https://github.com/macports/macports-ports/commit/e15b868be9e0beb26acd8656cde9becacdd78ba7 looks to have removed py35-pyqtgraph ... but when I do "port info py35-pyqtgraph" it works ... so I'm not sure what's going on here!

comment:5 Changed 5 years ago by michaelld (Michael Dickens)

Ah ... found it: py35- version was reinstated here: https://github.com/macports/macports-ports/commit/355ca641350637f63133056f4ba8b3fca9fa624c

Hence, I'm just removing the Py34 variant.

comment:6 Changed 5 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: assignedclosed

In 7508ae36815caed040cfc1ff9f9925667061023f/macports-ports (master):

gnuradio-next: remove +python34 variant

Closes: #59310

comment:7 in reply to:  2 ; Changed 5 years ago by jmroot (Joshua Root)

Cc: jjstickel added

Replying to jjstickel:

Obviously, the +python34 and +python35 variants should be removed from gnuradio-next.

And obviously, ports should not be removed without making sure that all dependencies on them have been removed first.

comment:8 Changed 5 years ago by michaelld (Michael Dickens)

@jmroot: +1

comment:9 in reply to:  7 Changed 5 years ago by jjstickel (Jonathan Stickel)

Replying to jmroot:

Replying to jjstickel:

Obviously, the +python34 and +python35 variants should be removed from gnuradio-next.

And obviously, ports should not be removed without making sure that all dependencies on them have been removed first.

Ok, sorry, and duly noted. I think at the time (>1 yr ago now) I was under the impression (due to an exchange with another developer) that py34 and py35 should not be used, and that is why I removed them in the patch/PR.

comment:10 Changed 5 years ago by michaelld (Michael Dickens)

@jjstickel: NP. really! doing diligence at the time of is always important since things change.

Note: See TracTickets for help on using tickets.