Opened 5 years ago
Closed 5 years ago
#59358 closed defect (fixed)
Add python2_qstring.diff debian patch to py-pyqt5 in order to fix pymol crashes under python27 and py27-pyqt5
| Reported by: | jwhowarth | Owned by: | mamoll (Mark Moll) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | py-pyqt5 |
Description
The attached Portfile.diff and python2_qstring.diff eliminates the crashes seen when pymol is run against py27-qt5 and python27.
Attachments (2)
Change History (8)
Changed 5 years ago by jwhowarth
| Attachment: | Portfile.diff added |
|---|
Changed 5 years ago by jwhowarth
| Attachment: | python2_qstring.diff added |
|---|
python2_qstring.diff patch to eliminate crashes seen under pymol with py27-pyqt5 and python27.
comment:1 Changed 5 years ago by jwhowarth
Confirmed the fix on Catalina under Xcode 11.1 by installing the proposed packaging and running 'pymol'.
comment:2 Changed 5 years ago by jmroot (Joshua Root)
| Keywords: | haspatch added |
|---|---|
| Owner: | set to mamoll |
| Port: | py-pyqt5 added; py-qt5 removed |
| Status: | new → assigned |
| Summary: | Add python2_qstring.diff debian patch to py-qtpy5 in order to fix pymol crashes under python27 and py27-pyqt5 → Add python2_qstring.diff debian patch to py-pyqt5 in order to fix pymol crashes under python27 and py27-pyqt5 |
| Type: | update → defect |
comment:3 Changed 5 years ago by jwhowarth
Also confirmed that fix on Mojave with Xcode 10.2.1 eliminates the pymol crashes with the python27 variant under the Qt interface.
comment:4 Changed 5 years ago by mamoll (Mark Moll)
@jwhowarth, the patch looks good to me. Feel free to commit.
comment:5 Changed 5 years ago by cjones051073 (Chris Jones)
https://github.com/macports/macports-ports/pull/5548
jwhowarth - In future please consider opening github PRs directly yourself rather than trac tickets with patchfiles. Its so much more convenient in terms to getting the fix applied.
comment:6 Changed 5 years ago by Chris Jones <jonesc@…>
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Portfile diff to add python2_qstring.diff to py-pyqt5