webkit2-gtk @2.26.1: on 10.12: error: reference to 'Handle' is ambiguous

[kencu (Ken)]

​https://build.macports.org/builders/ports-10.12_x86_64-builder/builds/103740/steps/install-port/logs/stdio

This is a name collision from MacTypes.h polluting the global namespace. It doesn't happen on 10.13+, interestingly. It did happen on 10.6.8, but not when built with clang-5.0. We'll see what systems show this error, and then decide on where to sanitize MacTypes.h (see details in the PR).

n file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-0284c6ac-1.cpp:8:
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_www_webkit2-gtk/webkit2-gtk/work/webkitgtk-2.26.1/Source/JavaScriptCore/tools/JSDollarVM.cpp:182:37: error: reference to 'Handle' is ambiguous
    bool isReachableFromOpaqueRoots(Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor, const char** reason) override
                                    ^
/usr/include/MacTypes.h:249:41: note: candidate found by name lookup is 'Handle'
typedef Ptr *                           Handle;
                                        ^
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_www_webkit2-gtk/webkit2-gtk/work/webkitgtk-2.26.1/Source/JavaScriptCore/heap/Handle.h:109:29: note: candidate found by name lookup is 'JSC::Handle'
template <typename T> class Handle : public HandleBase, public HandleConverter<Handle<T>, T> {
                            ^
1 error generated.

[kencu (Ken)]

I'm not sure about this one, yet. For reasons not fully clear, building with clang-5.0 avoids this error, whereas building with clang-9.0 shows it. Obviously something remains to be discovered, and as yet, I'm not ready to claim full success with the quartz variants either.

[kencu (Ken)]

fixed by the latest commmits to webkit2-gtk-devel upstream, and backported into webkit2-gtk