Opened 4 years ago

Closed 4 years ago

#59537 closed defect (fixed)

SDRangel: error: variable length array of non-POD element type 'complex<float>'

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: ra1nb0w
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: Cc: michaelld (Michael Dickens)
Port: SDRangel

Description

​SDRangel doesn't build on 10.11 at least: 

/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_science_SDRangel/SDRangel/work/sdrangel-4.11.11/plugins/channelrx/demoddatv/leansdr/dvbs2.h:736:35: error: variable length array of non-POD element type 'complex<float>'
        complex<float> pls_symbols[plscodes.LENGTH];
                                  ^

Change History (3)

comment:1 Changed 4 years ago by jmroot (Joshua Root)

This code is invalid according to standard C++. It looks like support for non-POD VLAs was added as an extension to match GCC in Clang 3.9. ​https://github.com/llvm/llvm-project/commit/e7545b33ff79c55d08d78a35b052e494ea49a0bc

comment:3 Changed 4 years ago by ra1nb0w

Resolution: → fixed
Status: assigned → closed

In 445aa33ee018fb8b1dc7e4789b7b2833e6b6568d/macports-ports (master):

SDRangel: fix build on macos <= 10.11

quick and dirty fix for
error: variable length array of non-POD element type 'complex<float>'

should be fine since it is a DSP library (DVB-S2 implementation) and
therefore not changed frequently; if something change, the patch fails
to apply.

Closes: #59537

Note: See TracTickets for help on using tickets.