ola @0.10.7 +libftdi0: error: use of undeclared identifier 'GOOGLE_CHECK'

[fdstevex (Steve Tibbett)]

As the summary says .. attempting to install ola with support for the Enttec Open DMX USB adapter on the Mac which requires the libftdi0 variant.

Full log attached. Summary:

sudo port install ola +libftdi0
Password:
--->  Computing dependencies for ola
--->  Fetching archive for ola
--->  Attempting to fetch ola-0.10.7_1+http+libftdi0+libusb+osc+python27.darwin_19.x86_64.tbz2 from https://packages.macports.org/ola
--->  Attempting to fetch ola-0.10.7_1+http+libftdi0+libusb+osc+python27.darwin_19.x86_64.tbz2 from http://ywg.ca.packages.macports.org/mirror/macports/packages/ola
--->  Attempting to fetch ola-0.10.7_1+http+libftdi0+libusb+osc+python27.darwin_19.x86_64.tbz2 from http://aus.us.packages.macports.org/macports/packages/ola
--->  Building ola
Error: Failed to build ola: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ola/ola/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port ola failed

[fdstevex (Steve Tibbett)]

First build output

[fdstevex (Steve Tibbett)]

Problem seems to be these build errors:

:info:build protoc/StrUtil.cpp:256:3: error: use of undeclared identifier 'GOOGLE_CHECK'
:info:build   GOOGLE_CHECK(i >= 0)
:info:build   ^
:info:build protoc/StrUtil.cpp:436:3: error: use of undeclared identifier 'GOOGLE_DCHECK_LT'
:info:build   GOOGLE_DCHECK_LT(digits, 100);

[ryandesign (Ryan Carsten Schmidt)]

This is an incompatibility with protobuf 3.7 and later. See ​https://github.com/OpenLightingProject/ola/issues/1550, which has not yet been resolved.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #59928.

[ryandesign (Ryan Carsten Schmidt)]

​This problem is still happening.

The ​upstream issue has been closed. Can we update to a fixed version or backport a fix to our version?

[peternewman (Peter Newman)]

Hi ryandesign,

For now you can backport the contents of ​https://github.com/OpenLightingProject/ola/pull/1630/files

Feel free to ignore the Python and Travis changes.

We're trying to get a release out soon, but other stuff keeps breaking us too:

​https://github.com/OpenLightingProject/ola/pull/1651

​https://github.com/OpenLightingProject/ola/pull/1641

[andyggraves]

Hi there, I posted a ticked #61374 which was closed as a duplicate and was pointed here. please explain how can i get ola to install? thanks

[kencu (Ken)]

There are the makings of a fairly simple patch for this issue here <​https://github.com/OpenLightingProject/ola/pull/1630/files>, as mentioned in [59585#comment:6]

[peternewman (Peter Newman)]

Hi Andy,

In the short term you can compile from git. See here: ​https://www.openlighting.org/ola/mac-install/

In the medium term, someone needs to for now update the package to add the patch I linked to, in the longer term we'll ship a new release which can be switched to and the patches removed.

Unfortunately I won't be able to do this (or at least test it) as our test Mac failed. I could make the changes and someone else could test it, or someone could do all the work. My Mac access is now limited to our Travis setup and whatever CI Macports runs.

I also don't seem to be able to unassign myself.

[mf2k (Frank Schima)]

Unfortunately I won't be able to do this (or at least test it) as our test Mac failed.

@peternewman: If you submit a GitHub PR, the buildbots will build it for you there.

[peternewman (Peter Newman)]

Yeah I was more meaning testing the resulting port Frank (or will it at least run our tests?), thanks for the heads up though.

[peternewman (Peter Newman)]

​https://github.com/macports/macports-ports/pull/8941

[mf2k (Frank Schima)]

Yes, it will run the port tests.

[ryandesign (Ryan Carsten Schmidt)]

Replying to mf2k:

@peternewman: If you submit a GitHub PR, the buildbots will build it for you there.

A combination of GitHub Actions, Azure Pipelines, and Travis CI do our PR builds. Buildbot is not involved. Our Buildbot setup only does builds after a commit appears on master.

Replying to mf2k:

Yes, it will run the port tests.

MacPorts does not run tests unless specifically asked to do so via sudo port test. None of our build infrastructure runs sudo port test.

[Peter Newman <peternewman@…>]

In dac3e04de992b31c833c29a42dd38c2067224079/macports-ports (master):

ola: Support newer protobuf3-cpp and libmicrohttpd

Closes: #59585

[peternewman (Peter Newman)]

Thanks Ryan. Hopefully Andy or Joshua can do that and/or will let us know if it doesn't work generally.

[mf2k (Frank Schima)]

Replying to ryandesign:

A combination of GitHub Actions, Azure Pipelines, and Travis CI do our PR builds. Buildbot is not involved.

Sorry for the nomenclature mix-up on my end. I did mean the GitHub build process.

None of our build infrastructure runs sudo port test.

My bad. I thought that the "Test ports" phase of the Azure pipelines meant running port test.

[andyggraves]

Hi there, It does seem to build now, however i am now seeing the following:

andygraves2@AGMBP ola % olad -l 3 dyld: Library not loaded: /opt/local/lib/libmicrohttpd.10.dylib

Referenced from: /usr/local/bin/olad Reason: image not found

zsh: abort olad -l 3

Thanks Andy

[peternewman (Peter Newman)]

Hi Andy,

That's good news.

I think you'll need to do the equivalent of a make clean. Or a port install may do the trick.

Can you share your build log too if that doesn't work as well as list of installed ports.