Opened 4 years ago

Closed 4 years ago

#59590 closed defect (fixed)

ipmitool @1.8.18.20190905: error: use of undeclared identifier 'rl_event_hook'

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: drkp (Dan Ports)
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: Cc:
Port: ipmitool

Description

ipmitool does not build:

/usr/bin/clang -DHAVE_CONFIG_H -I. -I..  -I../include -I/opt/local/include -Ds6_addr16=__u6_addr.__u6_addr16  -pipe -Os -arch x86_64 -Wall -Wextra -std=gnu11 -pedantic -Wformat -Wformat-nonliteral -MT ipmishell.o -MD -MP -MF .deps/ipmishell.Tpo -c -o ipmishell.o ipmishell.c
ipmishell.c:114:3: error: use of undeclared identifier 'rl_event_hook'
                rl_event_hook = rl_event_keepalive;
                ^
ipmishell.c:118:3: warning: implicit declaration of function 'rl_set_keyboard_input_timeout' is invalid in C99 [-Wimplicit-function-declaration]
                rl_set_keyboard_input_timeout(1000 * 1000 - 1);
                ^

This is not surprising to me, since rl_event_hook and rl_set_keyboard_input_timeout are in libreadline, and it is not linking with -lreadline here (though it is elsewhere; I don't know why it's not here).

Please check the other open tickets as well for other build failures.

Change History (3)

comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Port: ipmitool added; impitool removed
Summary: impitool @1.8.18.20190905: error: use of undeclared identifier 'rl_event_hook'ipmitool @1.8.18.20190905: error: use of undeclared identifier 'rl_event_hook'

comment:2 Changed 4 years ago by kencu (Ken)

the build fails if readline is not installed, and succeeds when it is installed.

comment:3 Changed 4 years ago by kencu (Ken)

Resolution: fixed
Status: assignedclosed

In c38f74ba9984edec64a6127dfac2a7bc4399d86b/macports-ports (master):

ipmitool: requires readline

closes: #59590

Note: See TracTickets for help on using tickets.