Changes between Initial Version and Version 1 of Ticket #60035, comment 4


Ignore:
Timestamp:
Apr 29, 2020, 2:19:47 PM (4 years ago)
Author:
kencu (Ken)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #60035, comment 4

    initial v1  
    33Jeremy wrote this in an unusual way, with backtiks in the the cmake configure line to drive pkg-config for the ffi flags.
    44
    5 without pkg-config, there was always a warning right after the cmake config line that pkg-config was not found, but never an error. Ryan opened a ticket about it.
     5without pkg-config, there was always a warning right after the cmake config line that pkg-config was not found, but never an error, as above.
    66
    77so I think the backtik line just produced an empty string for the ffi includes when pkg-config was not found, but it never actually errored. But it is used to generate the proper includes if it is found ( the warning is gone when pkgconfig is added).