Opened 4 years ago

Closed 2 years ago

#60063 closed defect (fixed)

xdm @1.1.12 fails to build on <= 10.8

Reported by: jmroot (Joshua Root) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: Schamschula (Marius Schamschula)
Port: xdm

Description

https://build.macports.org/builders/ports-10.8_x86_64-builder/builds/15608/steps/install-port/logs/stdio

In file included from auth.c:76:
/usr/include/net/if.h:306:19: error: field has incomplete type 'struct sockaddr'
                struct  sockaddr ifru_addr;

IIRC you need to include sys/socket.h before net/if.h. That would be done via dm_socket.h if TCPCONN were defined, but it's not because we don't configure with --enable-tcp-transport. It's not clear from my quick inspection what (if anything) the net/if.h include is needed for in these circumstances.

Change History (2)

comment:1 Changed 4 years ago by jmroot (Joshua Root)

Cc: Schamschula added

[cfb7200a702f63a69c4302d62a7c9074218796a2/macports-ports] removed the use of a patch that appears to have been working around this issue (though didn't delete the patch itself). Not sure if it was the most correct fix, but it seemed to work before.

comment:2 Changed 2 years ago by ken-cunningham-webuse

Resolution: fixed
Status: assignedclosed

In 2dfb34935e7200c0b03540b989f0da2ff0e6bffe/macports-ports (master):

xdm: restore socket.patch

fixed the build on 10.8 and less again
closes: #60063

Note: See TracTickets for help on using tickets.