#60116 closed defect (fixed)

mpv @0.31.0 fails to build on mavericks: macosx_menubar.m:718:67: error: property 'path' not found on object of type 'id'

Reported by: tehcog (tehcog) Owned by: Ionic (Mihai Moldovan)
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: haspatch Cc:
Port: mpv

Description

please see attached main.log

Attachments (2)

mpv_main.log (177.0 KB) - added by tehcog (tehcog) 14 months ago.
main.log
mpv-portfile-diff.diff (1.1 KB) - added by kencu (Ken) 11 months ago.

Download all attachments as: .zip

Change History (12)

Changed 14 months ago by tehcog (tehcog)

Attachment: mpv_main.log added

main.log

comment:1 Changed 14 months ago by mf2k (Frank Schima)

Cc: Ionic removed
Owner: set to Ionic
Status: newassigned

comment:2 Changed 14 months ago by kencu (Ken)

728	:info:build ../osdep/macosx_menubar.m:718:67: error: property 'path' not found on object of type 'id'
729	:info:build                                                   [panel URLs][0].path];
730	:info:build                                                                   ^
731	:info:build ../osdep/macosx_menubar.m:732:12: warning: 'NSTextField' may not respond to 'setPlaceholderString:'
732	:info:build     [input setPlaceholderString:@"URL"];
733	:info:build      ~~~~~ ^
734	:info:build 6 warnings and 1 error generated.

comment:3 Changed 14 months ago by kencu (Ken)

Summary: mpv @0.31.0 fails to build on mavericksmpv @0.31.0 fails to build on mavericks: macosx_menubar.m:718:67: error: property 'path' not found on object of type 'id'

comment:4 Changed 11 months ago by kencu (Ken)

This works:

--- multimedia/mpv/Portfile	2020-05-12 22:55:03.000000000 -0700
+++ multimedia/mpv/Portfile	2020-05-12 22:56:03.000000000 -0700
@@ -168,11 +168,13 @@
         compiler.blacklist-append   *gcc* cc macports-*
     }
 
-    if {${os.major} <= 10 || ${configure.build_arch} ne "x86_64"} {
+    if {${os.major} <= 15 || ${configure.build_arch} ne "x86_64"} {
         # Disable Cocoa output.
         # Users on old systems will need to embrace X11.
         configure.args-replace      --enable-cocoa \
                                     --disable-cocoa
+        configure.args-replace      --enable-swift \
+                                    --disable-swift
 
         default_variants-append     +x11
     }
@@ -477,7 +479,7 @@
 }
 
 variant opengl description {Enable OpenGL output support. Both the CoreVideo and X11 (GLX) outputs are supported} {
-    if {${os.platform} eq "darwin" && ${os.major} > 10} {
+    if {${os.platform} eq "darwin" && ${os.major} > 15} {
         configure.args-replace  --disable-gl-cocoa \
                                 --enable-gl-cocoa
     }

Changed 11 months ago by kencu (Ken)

Attachment: mpv-portfile-diff.diff added

comment:5 Changed 11 months ago by kencu (Ken)

So, caveats. This changes the port to use +x11 on older systems. I don't have the inclination to try to fix the objective-c and it's probably a waste of time as it changes frequently. And I just picked "darwin 15" out of the air -- that might or might not be the proper cutoff -- have to check the buildbots more carefully.

But with this patch, mpv installs on 10.7 without any trouble.

Last edited 11 months ago by kencu (Ken) (previous) (diff)

comment:6 Changed 11 months ago by kencu (Ken)

Keywords: haspatch added

comment:7 in reply to:  5 ; Changed 11 months ago by ryandesign (Ryan Schmidt)

Replying to kencu:

And I just picked "darwin 15" out of the air -- that might or might not be the proper cutoff -- have to check the buildbots more carefully.

Well according to the mpv port status page version 0.31.0 build successfully on OS X 10.11 (Darwin 15) and later and failed to build on OS X 10.10 (Darwin 14) and earlier.

comment:8 in reply to:  7 Changed 11 months ago by kencu (Ken)

Replying to ryandesign:

Well according to the mpv port status page version 0.31.0 build successfully on OS X 10.11 (Darwin 15) and later and failed to build on OS X 10.10 (Darwin 14) and earlier.

It's likely the same error -- but "no logs" so wasn't sure.

comment:9 Changed 11 months ago by kencu (Ken)

patch needs a bit more work. On 10.10, I had to also disable video toolbox if using x11.

There are so many variants in this port it makes my head spin.

comment:10 Changed 11 months ago by kencu (Ken)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.