Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#60161 closed defect (fixed)

fish @3.1.0: error: field has incomplete type 'struct itimerval'

Reported by: kencu (Ken) Owned by: kencu (Ken)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: l2dy (Zero King)
Port: fish

Description

:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_shells_fish/fish/work/fish-3.1.0/src/expand.cpp:20:
:info:build /usr/include/sys/proc.h:118:19: error: field has incomplete type 'struct itimerval'
:info:build         struct  itimerval p_realtimer;  /* Alarm timer. */

Attachments (2)

fish-fail-1068-clang9.log (127.8 KB) - added by kencu (Ken) 3 years ago.
patch-fish-src-expand-sys-time.diff (251 bytes) - added by kencu (Ken) 3 years ago.

Download all attachments as: .zip

Change History (8)

Changed 3 years ago by kencu (Ken)

Attachment: fish-fail-1068-clang9.log added

Changed 3 years ago by kencu (Ken)

comment:1 Changed 3 years ago by kencu (Ken)

which systems need this? this was found on 10.6.8.

comment:2 Changed 3 years ago by kencu (Ken)

looks like at least 10.12 and less need this patch. Probably fine to apply it always -- must be getting pulled in some other way on 10.14 and up. Not sure about 10.13 -- no buildbot at present.

comment:3 Changed 3 years ago by kencu (Ken)

Owner: set to kencu
Resolution: fixed
Status: newclosed

In 0bd38993a0c22ec3e6d665b0b1b5d4ce4bd612cf/macports-ports (master):

fish: add missing sys/time.h header

this header is automatically included by newer OS versions
of proc.h, but is not included on older systems

closes: #60161

comment:4 Changed 3 years ago by l2dy (Zero King)

Cc: l2dy added

Ken, can you report or PR this upstream? We would have one less patch to maintain if they merged it.

comment:6 Changed 3 years ago by kencu (Ken)

yep, checked that myself. They also added a comment for clang-format. We can remove our patch when they get around to a new release.

Note: See TracTickets for help on using tickets.