Opened 4 years ago

Closed 20 months ago

#60270 closed defect (duplicate)

gegl and 64bit support leopard

Reported by: rmottola (Riccardo) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version:
Keywords: leopard Cc:
Port: gegl

Description

Adventuring compiling 64bit on 10.5 yields this failure:

../gegl-0.4.22/gegl/gegl-config.c:275:5: error: unknown type name 'vm_statistics64_data_t'; did you mean 'vm_statistics_data_t'?
    vm_statistics64_data_t vm_stat;
    ^~~~~~~~~~~~~~~~~~~~~~
    vm_statistics_data_t
/usr/include/mach/vm_statistics.h:100:30: note: 'vm_statistics_data_t' declared here
typedef struct vm_statistics    vm_statistics_data_t;
                                ^

As a workaround I propose to patch gegl/gegl-config.c

and transform line 274 from

#if defined(__LP64__)

to

#if defined(__LP64__) && defined(MAC_OS_X_VERSION_10_6)

to enable the 64bit structures only on newer os. Maybe another test like darwin version is more appropriate?

Change History (6)

comment:1 Changed 4 years ago by kencu (Ken)

I fixed this before -- did the fix disappear? IIRC, there was a bit more to the fix than this... let me see if I can find it...

comment:2 Changed 4 years ago by kencu (Ken)

see #58524 for the patch I did before

comment:3 Changed 4 years ago by kencu (Ken)

Oh, BTW, instead of this, which looks nice but in reality doesn't really work out as well as you would hope:

defined(MAC_OS_X_VERSION_10_6)

the convention is to use this, if the code is only known in the 10.6+ SDK

MAC_OS_X_VERSION_MAX_ALLOWED >= 1060

or this if the code can only run on on the 10.6+ SDK.

MAC_OS_X_VERSION_MIN_REQUIRED >= 1060

because it is much more reliable and will work on ever OS version from 10.4 to whatever comes along...

comment:4 Changed 4 years ago by jmroot (Joshua Root)

Owner: set to dbevans
Status: newassigned

comment:5 Changed 2 years ago by mascguy (Christopher Nielsen)

Owner: changed from dbevans to mascguy

Reassign gegl-related tickets to me

comment:6 Changed 20 months ago by mascguy (Christopher Nielsen)

Resolution: duplicate
Status: assignedclosed

Duplicate of issue:58524

Note: See TracTickets for help on using tickets.