Opened 4 years ago
Closed 4 years ago
#60605 closed defect (fixed)
bootstrap.sh needlessly downloads PortIndex.json
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | admin@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | server/hosting | Version: | |
| Keywords: | Cc: | ||
| Port: |
Description
_ci/bootstrap.sh rsyncs "PortIndex*" from the rsync server. This includes PortIndex and PortIndex.quick, which are needed, and PortIndex.json, which is not needed. I hope it is possible to update the script so that it requests and receives PortIndex and PortIndex.quick in a single transaction, without PortIndex.json. We don't want to fix the problem by making two separate connections to the server.
Change History (4)
comment:1 Changed 4 years ago by jmroot (Joshua Root)
comment:2 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
Oh. Well here's the PR I made before I read that comment. If we only want to sync PortIndex, then it can be even simpler. I guess the motivation is to do whatever is fastest, since this is for our CI systems, some of which (Travis) limit the maximum amount of time a build can run.
comment:3 Changed 4 years ago by jmroot (Joshua Root)
When I say very fast, it's around 150 ms on my system. I haven't measured lately but I think transferring the extra file over the internet would take longer.
comment:4 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
It is very fast (and automatic) to regenerate PortIndex.quick from PortIndex, which is why
port syncdoesn't even bother syncing PortIndex.quick. This probably doesn't need to either.