PDAL @2.1.0: binding of reference to type 'value_type' (aka 'pdal::PointRef') to a value of type 'const reference' (aka 'const pdal::PointRef') drops qualifiers

[ryandesign (Ryan Carsten Schmidt)]

​PDAL doesn't build:

[ 21%] Building CXX object CMakeFiles/pdalcpp.dir/filters/SplitterFilter.cpp.o
/usr/bin/clang++  -DUNIX -Dpdalcpp_EXPORTS -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/vendor/gtest/include -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/vendor/gtest -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/build/include -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/vendor -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/vendor/eigen -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/vendor/pdalboost -I/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/vendor/nlohmann -I/opt/local/include -I/opt/local/include/libxml2  -pipe -Os -DNDEBUG -I/opt/local/include -stdlib=libc++ -arch x86_64 -mmacosx-version-min=10.9 -fPIC   -Wall -Wextra -Wpointer-arith -Wcast-align -Wcast-qual -Wno-error=parentheses -Wno-error=cast-qual -Wredundant-decls -Wno-unused-parameter -Wno-unused-variable -Wno-long-long -Wno-unknown-pragmas -Wno-deprecated-declarations -Wno-unknown-warning-option -std=c++11 -o CMakeFiles/pdalcpp.dir/filters/SplitterFilter.cpp.o -c /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SplitterFilter.cpp
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.cpp:35:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.hpp:37:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/pdal/Filter.hpp:37:
In file included from /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/pdal/Stage.hpp:37:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/list:174:
In file included from /Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/memory:600:
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/iterator:940:14: error: binding of reference to type 'value_type' (aka 'pdal::PointRef') to a value of type 'const reference' (aka 'const pdal::PointRef') drops qualifiers
      return static_cast<reference>(*__i);
             ^                      ~~~~
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/algorithm:4245:20: note: in instantiation of member function 'std::__1::move_iterator<pdal::PointViewIter>::operator*' requested here
        if (__comp(*__first2, *__first1))
                   ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/algorithm:4305:9: note: in instantiation of function template specialization 'std::__1::__merge<<lambda at /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.cpp:68:16> &, std::__1::move_iterator<pdal::PointRef *>, std::__1::move_iterator<pdal::PointViewIter>, pdal::PointViewIter>' requested here
        __merge<_Compare>(move_iterator<value_type*>(__buff),
        ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/algorithm:4348:13: note: in instantiation of function template specialization 'std::__1::__buffered_inplace_merge<<lambda at /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.cpp:68:16> &, pdal::PointViewIter>' requested here
            __buffered_inplace_merge<_Compare>(__first, __middle, __last, __comp, __len1, __len2, __buff);
            ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/algorithm:4632:5: note: in instantiation of function template specialization 'std::__1::__inplace_merge<<lambda at /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.cpp:68:16> &, pdal::PointViewIter>' requested here
    __inplace_merge<_Compare>(__first, __m, __last, __comp, __l2, __len - __l2, __buff, __buff_size);
    ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/algorithm:4656:5: note: in instantiation of function template specialization 'std::__1::__stable_sort<<lambda at /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.cpp:68:16> &, pdal::PointViewIter>' requested here
    __stable_sort<_Comp_ref>(__first, __last, __comp, __len, __buf.first, __buf.second);
    ^
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.cpp:74:10: note: in instantiation of function template specialization 'std::__1::stable_sort<pdal::PointViewIter, <lambda at /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/PDAL-2.1.0-src/filters/SortFilter.cpp:68:16> >' requested here
    std::stable_sort(view.begin(), view.end(), cmp);
         ^
1 error generated.
make[2]: *** [CMakeFiles/pdalcpp.dir/filters/SortFilter.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_pdal/PDAL/work/build'

[Veence (Vincent)]

What version of MacOS / clang are you running?

[ryandesign (Ryan Carsten Schmidt)]

Per the link in the ticket description, this was on 10.9.

[ryandesign (Ryan Carsten Schmidt)]

PDAL still doesn't build on 10.10 and earlier. See ​https://ports.macports.org/port/PDAL/summary