Opened 16 months ago

Last modified 16 months ago

#60696 assigned defect

gdcm @3.0.5: fatal error: 'CharLS/charls.h' file not found

Reported by: ryandesign (Ryan Schmidt) Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: Cc: Veence (Vincent)
Port: gdcm, charls

Description

gdcm does not build with charls 2.1.0:

/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_science_gdcm/gdcm/work/gdcm-3.0.5/Utilities/gdcm_charls.h:21:11: fatal error: 'CharLS/charls.h' file not found
# include <CharLS/charls.h>
          ^

This makes sense since the buildbot workers use a case-sensitive filesystem and the file provided by charls 2.1.0 is charls/charls.h not CharLS/charls.h.

gdcm used to build successfully with charls 2.0.0 e.g. this log from 10.13. There the configure output says:

-- Found CHARLS: /opt/local/lib/libCharLS.dylib

What appears to have happened is that charls changed the capitalization of its include directory and library between 2.0.0 and 2.1.0. In 2.0.0, it's CharLS; in 2.1.0, it's charls.

Was this change in capitalization intentional? I don't see it mentioned in the charls 2.1.0 release notes. Nothing changed in the portfile between 2.0.0 and 2.1.0 to account for this. Veence, can you figure this out, maybe ask the developers of charls and determine which capitalization they intend to use from now on? Then we can make sure the charls port uses that capitalization in its include dir and library name. Then we can revbump and modify all ports that use charls to use that capitalization.

Change History (1)

comment:1 Changed 16 months ago by ryandesign (Ryan Schmidt)

Vince committed [bcc04bf03c5f6579a5a1a85ff795eb9785b2642c/macports-ports] to allow gdal to compile against the new charls. I guess that means we've decided that the change made in charls 2.1.0 is desired and will remain? If so, gdcm needs to be changed as well.

Note: See TracTickets for help on using tickets.