cgit-1.2.3: Undefined symbols for architecture x86_64: "_memrchr"

[iefdev (Eric F)]

Wanted to install cgit, and thought I should update it at the same time (we have v1.2.1).

But there's this build error: “ Undefined symbols for architecture x86_64: "_memrchr"”

$ grep -v 404 /opt/local/var/macports/logs/_opt_ports_dev_www_cgit/cgit/main.log | grep -C4 'error: '
:info:build Undefined symbols for architecture x86_64:
:info:build   "_memrchr", referenced from:
:info:build       _cgit_set_title_from_path in ui-shared.o
:info:build ld: symbol(s) not found for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build ../cgit.mk:133: recipe for target '../cgit' failed
:info:build make[1]: *** [../cgit] Error 1
:info:build make[1]: Leaving directory '/opt/local/var/macports/build/_opt_ports_dev_www_cgit/cgit/work/cgit-1.2.3/git'
:info:build Makefile:76: recipe for target 'cgit' failed

Search around, but no simular ones here in our Trac - but I found this one:

• ​gh:slact/nchan/issues/441
• -->​gh:slact/nchan/commit/e023c631

…if that helps.

———

Attachng the main.log, and necessary Portfile changes

Portfile data:

version             1.2.3

# See Makefile GIT_VER
set git_version     2.25.1


# ...

checksums           ${cgit_distfile} \
                    rmd160  4884b999302eb89afa67c73f07e8853f9402e681 \
                    sha256  5a5f12d2f66bd3629c8bc103ec8ec2301b292e97155d30a9a61884ea414a6da4 \
                    size    90632 \
                    ${git_distfile} \
                    rmd160  a8ab476982440c2cc94c7d21f619320d74f117d2 \
                    sha256  222796cc6e3bf2f9fd765f8f097daa3c3999bb7865ac88a8c974d98182e29f26 \
                    size    5875548

[ryandesign (Ryan Carsten Schmidt)]

You should report this problem to the developers of cgit so that they can fix it: ​https://lists.zx2c4.com/mailman/listinfo/cgit

[iEFdev]

Thanks Ryan… I've reported it now.

[iEFdev]

Update:

There was a patch to use that was sent if for this issue. I've applied it, and tested it - and it built ->installed without any errors.

We can use that one, until upstream has fixed it. I'll included the submitters commit msg in the head of the patch.

• ​https://lists.zx2c4.com/pipermail/cgit/2020-August/thread.html#4504
  • ​https://lists.zx2c4.com/pipermail/cgit/2020-August/004504.html
  • ​https://lists.zx2c4.com/pipermail/cgit/2020-August/004506.html

edit:

PR submitted: ​#8018

[Eric F <iEFdev@…>]

In bedbcce66fa0a8dcaed0aafba07267e7fe4b4ac1/macports-ports (master):

cgit: update to v1.2.3 (​https://github.com/macports/macports-ports/pull/8018)

• A patch has been added to fix the build error until upstream adds it.

Closes: #60967