golang portgroup sets default worksrcdir incorrectly

[jmroot (Joshua Root)]

set gopath              ${workpath}/gopath
default worksrcdir      {${gopath}/src/${go.package}}

This is wrong because worksrcdir is supposed to be a relative path. The corresponding full path, constructed from workpath and worksrcdir, is is worksrcpath.

[amake (Aaron Madlon-Kay)]

Thanks, it's weird that it was working anyway.

I've fixed this locally but I want to test all the existing golang ports before I push.

Memo: all ports using golang (currently 85) can be found with

find . -name Portfile | xargs grep -l -E 'PortGroup +golang' | xargs -n 1 dirname | xargs -n 1 basename

[jmroot (Joshua Root)]

Thanks. Yeah, I wasn't sure if anything was relying on this or I would have just fixed it myself.

[amake (Aaron Madlon-Kay)]

I think it was just an oversight; the correction is to simply make ${gopath} into a literal: gopath

I had two build failures: istioctl and kubergrunt. I will investigate them and make the fix if it's OK.

[amake (Aaron Madlon-Kay)]

The failures were unrelated; reported as #61184 and #61185

[Aaron Madlon-Kay <amake@…>]

In da7eb4eb859c0e9a22596d2cacabd6626af51852/macports-ports (master):

golang portgroup: fix worksrcdir

${worksrcdir} should be relative to ${workpath}

Closes #61182