Opened 12 months ago

Last modified 5 months ago

#61231 reopened defect

molden: error: implicit declaration of function

Reported by: p-walt Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.6.3
Keywords: bigsur catalina Cc: vikilyc (yuchen liu), valerie-vallet
Port: molden

Description

Hi there, I have tried multiple times to install molden using MacPorts. I have tried multiple versions of gcc and still get the same errors generated.

Attachments (2)

Error log.rtf (115.0 KB) - added by p-walt 12 months ago.
Log file of the failed building of the molden port
main.log (110.0 KB) - added by valerie-vallet 6 months ago.
compilation log file

Download all attachments as: .zip

Change History (9)

Changed 12 months ago by p-walt

Attachment: Error log.rtf added

Log file of the failed building of the molden port

comment:1 Changed 12 months ago by ryandesign (Ryan Schmidt)

Owner: set to ryandesign
Status: newaccepted
Summary: Failure to install molden portmolden: error: implicit declaration of function

Looks like there are many errors in the log of this form:

src/xwin.c:8709:4: error: implicit declaration of function 'plinz_' [-Werror,-Wimplicit-function-declaration]
   plinz_(isel,istat,
   ^

Implicit function declaration errors are a new problem we're having to contend with since the introduction of Xcode 12. Prior to that, this was only considered a warning. We should fix these problems, but until we do, you can avoid them by downgrading to Xcode 11 and/or the Xcode 11 version of the command line tools.

comment:2 Changed 9 months ago by ryandesign (Ryan Schmidt)

Cc: vikilyc added
Keywords: bigsur catalina added

Has duplicate #61985.

It is too difficult for me to fix errors in molden (the file that these errors occur in is over 92,000 lines long) so I will report it to the developer of molden for them to fix.

comment:3 Changed 6 months ago by ryandesign (Ryan Schmidt)

Cc: valerie-vallet added

I did report the problems to the developer. They did not respond to my email but did add -Wno-implicit-function-declaration to the build system, which I promptly removed because that is not the correct fix (it is not going to work on Apple Silicon systems). However since it has now been awhile and the developer has not fixed it the correct way, I will allow -Wno-implicit-function-declaration back into the build system and will instead mark the port as incompatible with Apple Silicon.

Last edited 6 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:4 Changed 6 months ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: acceptedclosed

In 2ddc57db263fc9a0be09ea1888a4893d4f6e6435/macports-ports (master):

molden: Allow build with Xcode 12 on x86_64

Closes: #61231

comment:5 Changed 6 months ago by ryandesign (Ryan Schmidt)

Correction: the developer did respond and I had not replied to reiterate the unsuitability of -Wno-implicit-function-declaration. I've now done that.

comment:6 Changed 6 months ago by valerie-vallet

Resolution: fixed
Status: closedreopened

Despite your fix, there are still compiling issues. See the attached log file

Changed 6 months ago by valerie-vallet

Attachment: main.log added

compilation log file

comment:7 Changed 5 months ago by ryandesign (Ryan Schmidt)

The developer removed -Wno-implicit-function-declaration again, perhaps because of my email letting them know it was not a suitable fix, but has not implemented any other fix, so the problems will continue until the developer fixes the problem. If the problem affects you, you could email the developer and let them know.

Note: See TracTickets for help on using tickets.