Opened 3 years ago

Closed 3 years ago

#61380 closed update (fixed)

samba4 upgrade to 4.13.0

Reported by: 21stcaveman (Hamid Maadani) Owned by: 21stcaveman (Hamid Maadani)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: 21stcaveman (Hamid Maadani)
Port: samba4

Description

I noticed samba4 has not been building for a long time. I just successfully built and ran v4.13.0 on MacOS Catalina (10.15.7), and want to share the fixes, in case they can be integrated for others to use. Here is a summary of changes :

  1. update Portfile, raise version to 4.13.0 with new checksums, add port python37 as a dependency
  2. apply a patch to change st_atim, st_ctim and st_mtim to mac compatible st_atimespec, st_ctimespec and st_mtimespec (patch-fix-st_atim.diff attached)
  3. apply a patch to disable build of docs on mac (patch-no-xsltproc.diff attached)

Let me know if it is easier or more appropriate to create a github merge request for this, I am new to macports system.

Attachments (2)

patch-fix-st_atim.diff (1.8 KB) - added by 21stcaveman (Hamid Maadani) 3 years ago.
patch-no-xsltproc.diff (1.7 KB) - added by 21stcaveman (Hamid Maadani) 3 years ago.

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by 21stcaveman (Hamid Maadani)

Attachment: patch-fix-st_atim.diff added

Changed 3 years ago by 21stcaveman (Hamid Maadani)

Attachment: patch-no-xsltproc.diff added

comment:1 Changed 3 years ago by 21stcaveman (Hamid Maadani)

Cc: 21stcaveman added

comment:2 Changed 3 years ago by 21stcaveman (Hamid Maadani)

Type: enhancementupdate

comment:3 Changed 3 years ago by mf2k (Frank Schima)

Thank you. Yes, please instead submit a GitHub pull request.

comment:4 in reply to:  3 Changed 3 years ago by 21stcaveman (Hamid Maadani)

Thanks. Done (https://github.com/macports/macports-ports/pull/8977)

Replying to mf2k:

Thank you. Yes, please instead submit a GitHub pull request.

Last edited 3 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

comment:5 Changed 3 years ago by 21stcaveman (Hamid Maadani)

Owner: set to 21stcaveman
Resolution: fixed
Status: newclosed

In 1fc6ea9d99cc90528cb08de10ed5b8eb113391ce/macports-ports (master):

samba4: Update to version 4.13.0

Closes: #61380

Note: See TracTickets for help on using tickets.