xcircuit: error: implicit declaration of function 'UDrawXAt' is invalid in C99

[dershow]

I had xcircuit installed and I allowed a number of ports to upgrade. One of them must have broken a link because after the upgrade macport reported that xcircuit was broken and that it would attempt to rebuild. However, the rebuild failed. I've attached the log file.

[ryandesign (Ryan Carsten Schmidt)]

Not related to a dependency. It's related to Xcode 12, because the error in the log is:

error: implicit declaration of function 'UDrawXAt' is invalid in C99

Until we fix it, you can work around it by downgrading to Xcode 11 and the Xcode 11 version of the command line tools.

[kurthindenburg (Kurt Hindenburg)]

The rev-upgrade errors appears to be "/opt/local/lib/libgs.9.52.dylib" - Ghostscript.

[ryandesign (Ryan Carsten Schmidt)]

Right, we need to revbump everything that links with ghostscript, minus those that were already done.

[dershow]

I see that there was a revbump from 3.9.73_7 to 3.9.73_8 but it still doesn't build for me. I see the same error in the log:

:info:build /usr/bin/clang -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"xcircuit\" -DVERSION=\"3.9\" -DHAVE_LIBM=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DSIZEOF_VOID_P=8 -DSIZEOF_UNSIGNED_INT=4 -DSIZEOF_UNSIGNED_LONG=8 -DSIZEOF_UNSIGNED_LONG_LONG=8 -DHAVE_LIBXT=1 -DSTDC_HEADERS=1 -DHAVE_SETENV=1 -DHAVE_PUTENV=1 -DHAVE_DIRENT_H=1 -DHAVE_LIBZ=1 -DHAVE_VA_COPY=1 -DHAVE___VA_COPY=1 -DHAVE_U_CHAR=1 -DHAVE_X11_XPM_H=1 -DHAVE_XPM=1 -DHAVE_CAIRO=1 -DHAVE_GHOSTSCRIPT_GDEVDSP_H=1 -DHAVE_GS=1 -DLGF=1 -DINPUT_FOCUS=1 -DGS_EXEC=\"/opt/local/bin/gs\" -DSPICE_EXEC=\"ngspice\" -DTCL_WRAPPER=1 -DPROG_VERSION=3.9 -DPROG_REVISION=73 -DCAD_DIR=\"/opt/local/lib\" -DTEMP_DIR=\"/tmp\" -DRESOURCES_DIR=\"/opt/local/lib/xcircuit-3.9/app-defaults\" -DSCRIPTS_DIR=\"/opt/local/lib/xcircuit-3.9\" -DBUILTINS_DIR=\"/opt/local/lib/xcircuit-3.9\" -DBUILTINS_FILE=\"\" -DUSER_RC_FILE=\".xcircuitrc\" -DPROLOGUE_DIR=\"/opt/local/lib/xcircuit-3.9\" -DPROLOGUE_FILE=\"xcircps2.pro\" -DCYRILLIC_ENC_FILE=\"cyrillic.enc\" -DISOLATIN2_ENC_FILE=\"isolatin2.enc\" -DISOLATIN5_ENC_FILE=\"isolatin5.enc\" -DSTARTUP_FILE=\"xcstartup.tcl\" -DLGF_LIB=\"lgf.lps\" -DASG_SPICE_LIB=\"asg_spice.lps\" -I. -IXw -I/opt/local/include -I/opt/local/include  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk  -I/opt/local/include -I/opt/local/include/cairo -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/pixman-1 -I/opt/local/include/ossp -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include/ossp -I/opt/local/include/freetype2 -I/opt/local/include/libpng16  -pipe -Os -Wno-return-type -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -arch x86_64 -Wno-pointer-sign -fno-common  -pedantic -Wall -Wextra -c -o text.o text.c
:info:build functions.c:1977:4: error: implicit declaration of function 'UDrawXAt' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build    UDrawXAt(&wpt);
:info:build    ^
:info:build functions.c:1977:4: note: did you mean 'UDrawX'?
:info:build functions.c:1972:6: note: 'UDrawX' declared here
:info:build void UDrawX(labelptr curlabel)
:info:build      ^
:info:build functions.c:1989:4: error: implicit declaration of function 'UDrawXAt' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build    UDrawXAt(&wpt);
:info:build    ^
:info:build functions.c:2917:38: warning: format specifies type 'int' but the argument has type 'float' [-Wformat]
:info:build                           fprintf(f, "\\rotatebox{-%d}{", thislabel->rotation);
:info:build                                                    ~~     ^~~~~~~~~~~~~~~~~~~
:info:build                                                    %f
:info:build 1 warning and 2 errors generated.
:info:build make[2]: *** [functions.o] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....

[ken-cunningham-webuse]

In 5a8cc91c4a5096bd35053296ba1293fc1da7ef79/macports-ports (master):

xcircuit: fix implicit function decln

fixes:
functions.c:1989:4: error: implicit declaration of function 'UDrawXAt' is invalid in C99

closes: #61504

[kurthindenburg (Kurt Hindenburg)]

In 0b308c1ee623b1607f91602844306d796687b9bb/macports-ports (master):

xcircuit-devel: update to 3.10.30; add udrawxat patch

Patch taken from xcircuit by Ken Cunningham

See: #61504