xorg-libX11 @1.7.0 does not build on PPC Leopard, Mac OS X 10.5.8, because "error: #pragma GCC diagnostic not allowed inside functions"

[ballapete (Peter "Pete" Dyballa)]

/bin/sh ../../libtool  --tag=CC   --mode=compile /usr/bin/gcc-4.2 -std=gnu99 -DHAVE_CONFIG_H -I. -I../../src -I../../include/X11  -I../../include -I../../include/X11 -I../../include -I../../include/X11 -I../../src/xcms -I../../src/xkb -I../../src/xlibi18n -I../../src -D_BSD_SOURCE -I/opt/local/include -D_DEFAULT_SOURCE -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT    -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wimplicit -Wnonnull -Winit-self -Wmain -Wmissing-braces -Wsequence-point -Wreturn-type -Wtrigraphs -Wwrite-strings -Waddress -Wint-to-pointer-cast -Wpointer-to-int-cast -fno-strict-aliasing -pipe -Os -arch ppc -MT XKBBind.lo -MD -MP -MF .deps/XKBBind.Tpo -c -o XKBBind.lo XKBBind.c
libtool: compile:  /usr/bin/gcc-4.2 -std=gnu99 -DHAVE_CONFIG_H -I. -I../../src -I../../include/X11 -I../../include -I../../include/X11 -I../../include -I../../include/X11 -I../../src/xcms -I../../src/xkb -I../../src/xlibi18n -I../../src -D_BSD_SOURCE -I/opt/local/include -D_DEFAULT_SOURCE -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wimplicit -Wnonnull -Winit-self -Wmain -Wmissing-braces -Wsequence-point -Wreturn-type -Wtrigraphs -Wwrite-strings -Waddress -Wint-to-pointer-cast -Wpointer-to-int-cast -fno-strict-aliasing -pipe -Os -arch ppc -MT XKBBind.lo -MD -MP -MF .deps/XKBBind.Tpo -c XKBBind.c  -fno-common -DPIC -o .libs/XKBBind.o
XKBBind.c: In function ‘XLookupKeysym’:
XKBBind.c:230: error: #pragma GCC diagnostic not allowed inside functions
XKBBind.c:231: error: #pragma GCC diagnostic not allowed inside functions
XKBBind.c:233: warning: ‘XKeycodeToKeysym’ is deprecated (declared at XKBBind.c:103)
XKBBind.c:237: error: #pragma GCC diagnostic not allowed inside functions
make[3]: *** [XKBBind.lo] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_xorg-libX11/xorg-libX11/work/libX11-1.7.0/src/xkb'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_xorg-libX11/xorg-libX11/work/libX11-1.7.0/src'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_xorg-libX11/xorg-libX11/work/libX11-1.7.0/src'
make: *** [all-recursive] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_x11_xorg-libX11/xorg-libX11/work/libX11-1.7.0'

The the cure is to use GCC7?

[ballapete (Peter "Pete" Dyballa)]

Main.log from PPC Leopard

[ballapete (Peter "Pete" Dyballa)]

Using configure.compiler=macports-gcc-7 lets xorg-libX11 build.

[kencu (Ken)]

In b2bc6da4d98143000e7534de4f7a931c60eca3a4/macports-ports (master):

xorg-libX11: fix build with older gcc compilers

move pragmas outside functions
no revbump - harmless to current builds

closes: #61613

[kencu (Ken)]

gcc7 would have been fine, Peter -- and we can see that coming -- but it turned out that (for now) there was just the one pragma to move so I elected to do that instead and keep this software building with the older compilers for now.