p5-www-curl @4.17: error: use of undeclared identifier 'CURL_WIN32' 'CURLOPT'

[ryandesign (Ryan Carsten Schmidt)]

p5-www-curl seems to be doing something that is not compatible with macOS, at least not macOS Big Sur (maybe #defineing something that's now being used in the system headers?) because the build log is just lots of errors that appear to be in the system headers:

​https://build.macports.org/builders/ports-11_arm64-builder/builds/1076/steps/install-port/logs/stdio

Locating required external dependency bin:curl-config... found at /opt/local/bin/curl-config.
The version is libcurl 7.73.0
Found curl.h in /opt/local/include/curl/curl.h
In file included from /opt/local/include/curl/curl.h:38:
In file included from /opt/local/include/curl/system.h:430:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/sys/types.h:184:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/sys/_types/_fd_def.h:32:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/Availability.h:136:
/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/AvailabilityInternal.h:142:2: error: #endif without #if
#endif /* #if defined(__has_builtin) */
 ^

[ryandesign (Ryan Carsten Schmidt)]

Same problem reported upstream in October 2015:

​https://rt.cpan.org/Public/Bug/Display.html?id=107825

No reply from developer to this or other bugs in recent years.

I guess WWW::Curl is dead.

Also no reply from maintainer in this bug report in one year.

I don't see anything that depends on this port. Maybe it should be removed.

[ryandesign (Ryan Carsten Schmidt)]

The above errors occur during the configuration phase but don't actually stop the build. I don't know how detrimental those errors are—maybe not at all since I guess they've been occurring since at least 2015 yet we've had successful builds of the port up to 2019.

The fatal errors don't occur until the build phase in which we have:

In file included from Curl.xs:578:
./curlopt-constants.c:188:46: error: use of undeclared identifier 'CURL_WIN32'
            if (strEQ(name, "WIN32")) return CURL_WIN32;
                                             ^
./curlopt-constants.c:2660:48: error: use of undeclared identifier 'CURLOPT'
            if (strEQ(name, "CURLOPT")) return CURLOPT;
                                               ^

This was reported upstream in March 2020 here:

​https://rt.cpan.org/Public/Bug/Display.html?id=132197

There is a patch provided there.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign:

/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/AvailabilityInternal.h:142:2: error: #endif without #if

This is discussed here:

​https://rt.cpan.org/Public/Bug/Display.html?id=131089
​https://github.com/szbalint/WWW--Curl/issues/16#issuecomment-558645508
​https://stackoverflow.com/questions/42031921/unterminated-unconditional-directive-error-when-preprocessing-c-code

It seems to happen because WWW::Curl's Makefile.PL invokes cpp and cpp has a bug that makes it unable to parse these system headers. The fix is apparently to use $CC -E instead of cpp, if we can figure out how to get the value of $CC in Makefile.PL.

[ryandesign (Ryan Carsten Schmidt)]

​https://github.com/macports/macports-ports/pull/13096

[ryandesign (Ryan Carsten Schmidt)]

In f4e33b098f4255f1fed14fb8dcc2b467cd30302b/macports-ports (master):

p5-www-curl: Fix build failures with recent curl

Add patch to fix build failure with recent curl.

Add patch to fix spurious error messages when using recent Xcode cpp.

Closes: #61622

Increase revision to rebuild to pick up new curl symbols. Add comment to
curl port reminding us to do this in the future when curl is updated.