calc @2.12.6.8: error: expected parameter declarator

[leuliett (Eric Leuliette)]

The function declarations for memmove and __builtin___memmove_chk in alloc.h aren't compatible with the include files with Xcode12.2/BigSure: /Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/secure/

[leuliett (Eric Leuliette)]

calc/main.log

[ryandesign (Ryan Carsten Schmidt)]

:info:build ../alloc.h:88:14: error: expected parameter declarator
:info:build E_FUNC void *memmove(void *s1, CONST void *s2, MEMMOVE_SIZE_T n);
:info:build              ^
:info:build /Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/secure/_string.h:70:47: note: expanded from macro 'memmove'
:info:build                 __builtin___memmove_chk (dest, __VA_ARGS__, __darwin_obsz0 (dest))
:info:build                                                             ^

It looks like it's trying to redefine the standard memmove function. The project's build system has code that's supposed to determine whether the system has a standard memmove function; that determination might not be working correctly in this case.

If this were a normal autotools project we would look for implicit declaration of function errors in the config.log but this project does not use autotools and does not have a config.log so I'm not sure if the errors are saved anywhere for us to look at.

The determination of memmove availability is made using the source file have_memmv.c. In that file I see that it is trying to use the function memmove but does not have the line #include <string.h> which is where that function is defined. Adding that line to that file may help, but there may be other tests that need similar fixes.

It looks like we could get the build system to disable quiet mode and thus maybe see the results of running these tests by adding Q= to the build args.

A new version of calc is available. We should probably start by updating to that version and see if that improves the situation.

[mrichmon (Michael Richmond)]

Attempted basic compile of current latest calc-2.12.7.1 code. Same memmove type error occurs. Opened issue on calc github repo: ​https://github.com/lcn2/calc/issues/19

[pmetzger (Perry E. Metzger)]

FYI, apparently this is all fixed in 2.12.7.5 — if someone wants to submit patches to update to that version, it would be welcome. I will get to it eventually if no one else does.

[pmetzger (Perry E. Metzger)]

I've now updated to 2.12.7.5. I haven't tried the build on Apple Silicon but I suspect that will now work as well.