Opened 3 years ago
Closed 3 years ago
#61799 closed defect (fixed)
gimp2 @2.10.22: export as gif or png does not display dialog
| Reported by: | pietvo (Pieter van Oostrum) | Owned by: | dbevans (David B. Evans) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.6.4 |
| Keywords: | haspatch | Cc: | mascguy (Christopher Nielsen), michaellass (Michael Lass) |
| Port: | gimp2 |
Description
The gimp2 port has missing dialogs for export as gif or png. Only a basoc dialog appears, not the complete dialog where you can specify options such as animation for a gif.
I traced the issue back to a wrong value of gimp_data_directory. It is not set, probably just the empty string. Both plugins (file-save-gif and file-save-png) use this value to find their ui file. For plugins it is not set properly, because in this version og gimp, plugins are in their own subdirectory within the plug-ins directory, and the algorithm in libgimpbase/gimpenv.c assumes that they are directly in the plug-ins directory. I have a patch for this. I added code for the subdirectory case (but I left the possibility of having a plugin directly in the plug-ins directory).
Attachments (1)
Change History (17)
Changed 3 years ago by pietvo (Pieter van Oostrum)
| Attachment: | 0001-Calculate-top-level-directory-for-plugins-within-a-d.patch added |
|---|
comment:1 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added; gimp plugin file save gif png removed |
|---|---|
| Owner: | set to dbevans |
| Port: | gimp2 added |
| Status: | new → assigned |
| Summary: | gimp2 2.10.22 export as gif or png does not display dialog → gimp2 @2.10.22: export as gif or png does not display dialog |
Did you invent this patch or does it come from the developers of gimp? If it comes from them, what is the URL? If you invented it, please send it to them and give us the URL of your submission.
comment:2 Changed 3 years ago by mascguy (Christopher Nielsen)
| Cc: | mascguy added |
|---|
comment:3 Changed 3 years ago by pietvo (Pieter van Oostrum)
I also submitted it to the Gimp tracker (https://gitlab.gnome.org/GNOME/gimp/-/issues/6018), but it takes a new release for it to become effective. So I want to propose to implement this as a patch in macports until it has been effectuated upstream.
comment:4 Changed 3 years ago by mascguy (Christopher Nielsen)
Pieter, as a GIMP user, I was recently bitten by this issue too. Thank you so much for submitting a patch to the upstream project!
Also, I just commented on your gitlab issue, asking if there's anything we can do to help. Perhaps that might help increase its visibility.
In the interim, it would be great to include this patch for the GIMP port. Does anyone mind if I submit a pull request?
comment:5 Changed 3 years ago by mascguy (Christopher Nielsen)
Tested GIMP with this patch, and it works beautifully. Thanks again Pieter!
Pull request created:
comment:7 Changed 3 years ago by mascguy (Christopher Nielsen)
Quick update: While upstream hasn't merged the patch just yet, so far the consensus is that it's necessary.
In the interim, I'd really like to see us use it, given that it fixes a fundamental issue in GIMP: Try exporting an image to GIF or PNG, and you'll immediately see why.
Dave, if you're around... can you please chime in? Otherwise, can someone approve the PR?
comment:8 Changed 3 years ago by mascguy (Christopher Nielsen)
Update: upstream has reviewed, and officially approved this patch. They'll be merging shortly.
comment:9 Changed 3 years ago by michaellass (Michael Lass)
| Cc: | michaellass added |
|---|
comment:10 follow-up: 14 Changed 3 years ago by mascguy (Christopher Nielsen)
Ken was kind enough to explain that GIMP is generally not touched by anyone other than the maintainer, and that's certainly reasonable. And the maintainer generally doesn't add patches like this, preferring to wait until they've been merged upstream. Also very reasonable.
Given that upstream merged the changes in today, we'll at least see this fix in the next GIMP release. In the interim, this ticket can be closed, with a status of "wontfix."
comment:11 Changed 3 years ago by bootchk (Lloyd Konneker)
The root cause (identified by Pieter) in GIMP also manifests with the symptom: in the console 'Script-Fu initialization file not found: error "Unable to read initialization file script-fu.init" ' and then many of the GIMP menu items (those implemented by ScriptFu) do not appear in the GUI. Which is also fixed by the same upstream commits.
GIMP releases seem to be about six months apart now. 2.10.22 was Oct 2020, so 2.10.24 should be out soon. 2.10.24 should include the two month old commit that fixes these.
(However, see GIMP #6578, there is an issue with Scriptfu dialogs hanging on MacOS. I doubt any fix will make it into 2.10.24. Anyone here know more about extra polling of the event loop in GLib on MacOS?)
comment:12 Changed 3 years ago by mascguy (Christopher Nielsen)
GIMP 2.10.24 has been released:
https://www.gimp.org/news/2021/03/29/gimp-2-10-24-released/
comment:13 Changed 3 years ago by mascguy (Christopher Nielsen)
PR created for update to 2.10.24:
PR 11772 - gimp2: update to 2.10.24
This fix is included in that update, as upstream merged it for 2.10.24.
comment:14 Changed 3 years ago by kencu (Ken)
Replying to mascguy:
Ken was kind enough to explain that GIMP is generally not touched by anyone other than the maintainer
That was true back then -- but I think MacPorts has lost Dave now, for at least the time being, and possibly ... ?
comment:15 Changed 3 years ago by mascguy (Christopher Nielsen)
Ken, I'm formally taking on maintainership of GIMP, and its numerous dependencies. If/when Dave resurfaces, he's welcome to retake the role of primary. But at this point, that's now me.
comment:16 Changed 3 years ago by i0ntempest
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
patch to apply to the gimp source code