qt513-qtwebengine @5.13.2_2: Exception: No 10.15.6+ SDK found

[dliessi (Davide Liessi)]

On macOS 10.15, qt513-qtwebengine fails with this error:

Project MESSAGE: Running: /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/3rdparty/gn/out/Release/gn gen /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/core/release --script-executable=/opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin/python2 --args='use_qt=true closure_compile=false is_component_build=false is_shared=true enable_message_center=false enable_mus=false enable_nacl=false enable_remoting=false enable_reporting=false enable_swiftshader=false enable_web_auth=false enable_web_speech=false enable_widevine=true has_native_accessibility=false enable_debugallocation=false use_allocator_shim=false use_allocator="none" use_custom_libcxx=false v8_use_external_startup_data=false toolkit_views=false treat_warnings_as_errors=false safe_browsing_mode=0 optimize_webui=false use_jumbo_build=true jumbo_file_merge_limit=8 jumbo_build_excluded=["browser"] enable_basic_printing=true enable_print_preview=true enable_pdf=true enable_plugins=true enable_spellcheck=true enable_webrtc=true enable_extensions=true enable_precompiled_headers=false is_official_build=true is_debug=false symbol_level=0 remove_webcore_debug_symbols=true remove_v8base_debug_symbols=true optimize_for_size=true v8_use_snapshot=true use_kerberos=true is_clang=true use_sysroot=false clang_base_path="/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr" clang_use_chrome_plugins=false mac_deployment_target="10.15" mac_sdk_min="10.15.6" use_external_popup_menu=false use_browser_spellchecker=true qtwebengine_target="/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/core/release:QtWebEngineCore"' --root=/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/3rdparty/chromium 
ERROR at //build/config/mac/mac_sdk.gni:68:5: Script returned non-zero exit code.
    exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines")
    ^----------
Current dir: /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/core/release/
Command: /opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin/python2 /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/3rdparty/chromium/build/mac/find_sdk.py --print_sdk_path 10.15.6
Returned 1.
stderr:

Traceback (most recent call last):
  File "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/3rdparty/chromium/build/mac/find_sdk.py", line 104, in <module>
    print main()
  File "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_aqua_qt513/qt513-qtwebengine/work/qtwebengine-everywhere-src-5.13.2/src/3rdparty/chromium/build/mac/find_sdk.py", line 77, in main
    raise Exception('No %s+ SDK found' % min_sdk_version)
Exception: No 10.15.6+ SDK found

See //build/config/sysroot.gni:64:3: whence it was imported.
  import("//build/config/mac/mac_sdk.gni")
  ^--------------------------------------
See //chrome/installer/BUILD.gn:7:1: whence it was imported.
import("//build/config/sysroot.gni")
^----------------------------------
See //BUILD.gn:71:5: which caused the file to be included.
    "//chrome/installer",
    ^-------------------
Project ERROR: GN run error!

See the ​full log.

I noticed that on 10.12, 10.13 and 10.14 the command contains mac_sdk_min="10.1X" (X being respectively 2, 3, and 4), while on 10.15 that argument is mac_sdk_min="10.15.6": maybe that is the problem.

[davidbeauchamp (David Beauchamp)]

With Qt 5.15.2 on Catalina w/Xcode 11.1, I had to change qtwebengine/src/3rdparty/chromium/build/mac/find_sdk.py to look for 11.x+ SDKs. Lines 91-93 wound up looking like this, in case it helps anyone else:

  sdks = [re.findall('^MacOSX(11\.\d+)\.sdk$', s) for s in os.listdir(sdk_dir)]
  sdks = [s[0] for s in sdks if s]  # [['11.0'], ['11.1']] => ['11.0', '11.1']
  sdks = [s for s in sdks  # ['11.0', '11.1'] => ['11.1']

[kencu (Ken)]

thanks -- I'll give that a try and patch it if I see the same events.

[JulianGro (Julian Groß)]

Replying to davidbeauchamp:

With Qt 5.15.2 on Catalina w/Xcode 11.1, I had to change qtwebengine/src/3rdparty/chromium/build/mac/find_sdk.py to look for 11.x+ SDKs.

How come you need to have it look for 11.x+ SDKs when using Xcode 11.1 which comes with 10.15 SDK? Isn't it going to at least throw a bunch of warnings when using QtWebEngine, when Qt has been built with 10.15.x and QtWebEngine has been built with 11.x?

[chrstphrchvz (Christopher Chavez)]

In d29983f7a1afeb74b3af8a5518ae881aaa30c1f3/macports-ports (master):

qt513-qtwebengine: fix macOS 11+ SDK detection

Fixes: #61924

[skip ci]

[chrstphrchvz (Christopher Chavez)]

This error still occurs on the 10.15 buildbot, which only has the 10.15.6 SDK. Backporting ​https://github.com/qt/qtwebengine/commit/5d2026c fixes this. See ​https://github.com/macports/macports-ports/pull/19017

[chrstphrchvz (Christopher Chavez)]

In b2d7dbf90fd5f07c6faffd961a84e849699de0c8/macports-ports (master):

qt513-qtwebengine: fix build on macOS 10.15

See: #61924#comment:7

[skip ci]

[chrstphrchvz (Christopher Chavez)]

patch-qtwebengine_sdk.diff also needs to be applied for qt513-qtwebengine-docs: ​https://github.com/macports/macports-ports/pull/19021

[chrstphrchvz (Christopher Chavez)]

In 3716aec1c6209a2b9b4517a1d2c3473323cb70d9/macports-ports (master):

qt513-qtwebengine-docs: fix build

See: #61924#comment:9