dict @1.13.0: fails to build from source

[ryanakca (Ryan Kavanagh)]

dict fails to build from source on

macOS 11.0.1 20B29
Xcode 12.2 12B45b

with the error

:info:build glibtool: compile:  /usr/bin/clang -c -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk -DHAVE_CONFIG_H -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk -arch x86_64 -DUSE_PLUGIN -DDICT_PLUGIN_PATH=\"/opt/local/libexec/\" -DDICT_DICTIONARY_PATH=\"/opt/local/share/\" -DDICT_VERSION=\"1.13.0\" -DDICT_CONFIG_PATH=\"/opt/local/etc/\" -I. -I. clientparse.c  -fno-common -DPIC -o .libs/clientparse.o
:info:build y.tab.c:1047:16: error: implicit declaration of function 'yylex' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       yychar = yylex ();
:info:build                ^
:info:build y.tab.c:1233:7: error: implicit declaration of function 'yyerror' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build       yyerror (YY_("syntax error"));
:info:build       ^
:info:build y.tab.c:1344:3: error: implicit declaration of function 'yyerror' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build   yyerror (YY_("memory exhausted"));
:info:build   ^
:info:build 3 errors generated.
:info:build make: *** [clientparse.o] Error 1

[ryanakca (Ryan Kavanagh)]

build log

[lbschenkel (Leonardo Brondani Schenkel)]

In cdbbdbabe61e371c36355b41e7ca8400a5de5fa1/macports-ports (master):

dict: fix build due to implicit declarations

Closes: #62015

[ryandesign (Ryan Carsten Schmidt)]

You can't just disable the error like that. You have to fix it correctly, by declaring the function before calling it (or including the header that does so). Otherwise the program may crash or otherwise misbehave on arm64.

[lbschenkel (Leonardo Brondani Schenkel)]

All right, thanks for the advice. I'm reopening this.

Unfortunately due to personal circumstances I'm very limited on time (and I don't even have or use Macs anymore, I'm using a VM just to be able to maintain the ports) so anything that's non trivial for me will drag on a bit. In case you know how best to fix this, please paste here or feel free to commit directly.

[ryandesign (Ryan Carsten Schmidt)]

In 0a1a3d69b2ba77d24a0211ae1f648562ef130e47/macports-ports (master):

dict: Fix implicit declaration of functions

Closes: #62015