Opened 21 months ago

Last modified 7 weeks ago

#62339 assigned defect

MacVim wants to update through its built-in update mechanism

Reported by: szhorvat (Szabolcs Horvát) Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 2.6.4
Keywords: Cc: cooljeanius (Eric Gallager)
Port: MacVim

Description

When I start MacVim, it wants to auto-update (see attached screenshot). Since software that is part of MacPorts is updated/managed by MacPorts, should their built-in update mechanisms not be disabled?

Attachments (1)

Screenshot 2021-02-21 at 11.09.21.png (410.8 KB) - added by szhorvat (Szabolcs Horvát) 21 months ago.

Download all attachments as: .zip

Change History (7)

Changed 21 months ago by szhorvat (Szabolcs Horvát)

comment:1 Changed 21 months ago by ryandesign (Ryan Schmidt)

Cc: raimue removed
Owner: set to raimue
Status: newassigned

comment:2 Changed 20 months ago by szhorvat (Szabolcs Horvát)

MacVim is still prompting to do updates. If I let it update by itself, next time MacPorts won't be able to update it properly.

comment:3 Changed 20 months ago by raimue (Rainer Müller)

Thanks for confirming it is still a problem. Sparkle is supposed to be disabled, but apparently the option in the build system is not working as intended. I will have to check this again.

comment:4 Changed 20 months ago by cooljeanius (Eric Gallager)

Cc: cooljeanius added

comment:5 Changed 7 weeks ago by szhorvat (Szabolcs Horvát)

This problem is still present.

comment:6 Changed 7 weeks ago by raimue (Rainer Müller)

Analyzing the history, I think the problem was introduced with 6418dc0d7fa5fa66993a2959a3704cd0196c4b38 as since then Sparkle.framework is no longer removed from the Xcode project.

Upstream also has a `--disable-sparkle` configure argument that we use and it is supposed to set the XCODEFLAGS to disable Sparkle.

However, the Portfile sets its own values for XCODEFLAGS and I would assume that the GCC_PREPROCESSOR_DEFINITIONS='$GCC_PREPROCESSOR_DEFINITIONS DISABLE_SPARKLE=1' is lost due to this.

One possible solution could be to include this GCC_PREPROCESSOR_DEFINITIONS in our XCODEFLAGS in the Portfile.

Note: See TracTickets for help on using tickets.