compiler_wrapper-1.0.tcl: spaces in arguments are lost

[ryandesign (Ryan Carsten Schmidt)]

The compiler wrappers created by the compiler_wrapper-1.0.tcl portgroup do not preserve spaces in arguments passed to them nor in MACPORTS_LEGACY_SUPPORT_CPPFLAGS.

Here is what a compiler wrapper currently looks like:

#!/bin/bash
export CCACHE_DIR=/opt/local/var/macports/build/.ccache
CMD="/opt/local/bin/ccache /usr/bin/clang ${MACPORTS_LEGACY_SUPPORT_CPPFLAGS} -pipe   ${@} "
exec ${CMD}

To correct the problem, it needs to look like this:

#!/bin/bash
export CCACHE_DIR=/opt/local/var/macports/build/.ccache
exec /opt/local/bin/ccache /usr/bin/clang "$MACPORTS_LEGACY_SUPPORT_CPPFLAGS" -pipe "$@"

Preservation of spaces only occurs when the variable name is surrounded in quotation marks.

"$@" is a special case. $@ represents potentially multiple arguments and "$@" expands to each of the arguments individually surrounded with quotation marks.

[cjones051073 (Chris Jones)]

should be fixed by ​https://github.com/macports/macports-ports/commit/0d92bdecdf30fd4372232ede2350a9f79fe4d9c1