Opened 3 years ago

Closed 3 years ago

#63122 closed defect (fixed)

cronolog @1.6.2, cronolog-devel @1.7.0-beta: error: implicitly declaring library function 'strcmp'

Reported by: cooljeanius (Eric Gallager) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.7.1
Keywords: bigsur catalina Cc: jberry@…
Port: cronolog, cronolog-devel

Description

Another victim of -Werror=implicit-function-declaration being on by default now:

/usr/bin/clang -DPACKAGE=\"cronolog\" -DVERSION=\"1.6.2\" -DTIME_WITH_SYS_TIME=1 -DHAVE_TM_ZONE=1 -DHAVE_FCNTL_H=1 -DHAVE_LIMITS_H=1 -DHAVE_UNISTD_H=1 -DHAVE_STRFTIME=1 -DHAVE_VPRINTF=1 -DHAVE_MKDIR=1 -DHAVE_MKTIME=1 -DHAVE_PUTENV=1 -DHAVE_STRPTIME=1 -DHAVE_LOCALTIME_R=1  -I. -I.    -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk  -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -arch x86_64 -c getopt.c
getopt.c:577:30: error: implicitly declaring library function 'strcmp' with type 'int (const char *, const char *)' [-Werror,-Wimplicit-function-declaration]
      if (optind != argc && !strcmp (argv[optind], "--"))
                             ^
getopt.c:577:30: note: include the header <string.h> or explicitly provide a declaration for 'strcmp'
getopt.c:653:7: error: implicitly declaring library function 'strncmp' with type 'int (const char *, const char *, unsigned long)' [-Werror,-Wimplicit-function-declaration]
        if (!strncmp (p->name, nextchar, nameend - nextchar))
             ^
getopt.c:653:7: note: include the header <string.h> or explicitly provide a declaration for 'strncmp'
getopt.c:656:21: error: implicitly declaring library function 'strlen' with type 'unsigned long (const char *)' [-Werror,-Wimplicit-function-declaration]
                == (unsigned int) strlen (p->name))
                                  ^
getopt.c:656:21: note: include the header <string.h> or explicitly provide a declaration for 'strlen'
getopt.c:704:6: warning: add explicit braces to avoid dangling else [-Wdangling-else]
                   else
                   ^
1 warning and 3 errors generated.
make[1]: *** [getopt.o] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_sysutils_cronolog/cronolog/work/cronolog-1.6.2/lib'
make: *** [all-recursive] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_sysutils_cronolog/cronolog/work/cronolog-1.6.2'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_sysutils_cronolog/cronolog/work/cronolog-1.6.2" && /usr/bin/make -j16 -w all 
Exit code: 2
Error: Failed to build cronolog: command execution failed
DEBUG: Error code: CHILDSTATUS 62471 2

Change History (2)

comment:1 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: jberry@… added; ryandesign removed
Owner: set to ryandesign
Port: cronolog-devel added
Status: newaccepted
Summary: cronolog @1.6.2: error: implicitly declaring library function 'strcmp'cronolog @1.6.2, cronolog-devel @1.7.0-beta: error: implicitly declaring library function 'strcmp'

comment:2 Changed 3 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: acceptedclosed

In 795640512ee14b82946e81d1513b828fecb35f68/macports-ports (master):

cronolog, cronolog-devel: Fix implicit func decls

Closes: #63122

Also modernize checksums and add revision line.

Note: See TracTickets for help on using tickets.