cvsdiff2patch @1.0.1_1: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]

[cooljeanius (Eric Gallager)]

Besides turning -Werror and/or -Wsystem-headers off, it looks like it also needs to be UsingTheRightCompiler and have the whitespace in its Portfile fixed and stuff:

SDKROOT='/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk'
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_cvsdiff2patch/cvsdiff2patch/work/cvsdiff2patch-1.0.1" && /opt/local/bin/bsdmake -j16 all 
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_cvsdiff2patch/cvsdiff2patch/work/cvsdiff2patch-1.0.1" && /opt/local/bin/bsdmake -j16 all 
"/opt/local/share/mk/bsdmake/bsd.compat.mk", line 36: warning: NOMAN is deprecated in favor of NO_MAN
Warning: Object directory not changed from original /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_cvsdiff2patch/cvsdiff2patch/work/cvsdiff2patch-1.0.1
cc -Os -pipe   -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -c cvsdiff2patch.c
In file included from cvsdiff2patch.c:34:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:64:
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:93:16: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
        unsigned char   *_base;
                        ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:93:16: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:93:16: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:138:32: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
        int     (* _Nullable _read) (void *, char *, int);
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:138:32: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:138:32: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:138:40: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
        int     (* _Nullable _read) (void *, char *, int);
                                                  ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:138:40: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:138:40: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:139:35: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
        fpos_t  (* _Nullable _seek) (void *, fpos_t, int);
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:139:35: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:139:35: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:140:32: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
        int     (* _Nullable _write)(void *, const char *, int);
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:140:32: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:140:32: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:140:46: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
        int     (* _Nullable _write)(void *, const char *, int);
                                                        ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:140:46: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:140:46: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:144:18: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
        struct __sFILEX *_extra; /* additions to FILE to not break ABI */
                        ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:144:18: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/_stdio.h:144:18: note: insert '_Nonnull' if the pointer should never be null
In file included from cvsdiff2patch.c:34:
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:67:13: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
extern FILE *__stdinp;
            ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:67:13: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:67:13: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:386:41: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
                 int (* _Nullable)(void *, const char *, int),
                                        ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:386:41: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:386:41: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:386:55: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
                 int (* _Nullable)(void *, const char *, int),
                                                      ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:386:55: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:386:55: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:387:44: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
                 fpos_t (* _Nullable)(void *, fpos_t, int),
                                           ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:387:44: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:387:44: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:388:41: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
                 int (* _Nullable)(void *));
                                        ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:388:41: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:388:41: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:384:6: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
FILE    *funopen(const void *,
        ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:384:6: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdio.h:384:6: note: insert '_Nonnull' if the pointer should never be null
In file included from cvsdiff2patch.c:36:
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:134:25: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
double   atof(const char *);
                         ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:134:25: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:134:25: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:135:22: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
int      atoi(const char *);
                         ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:135:22: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:135:22: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:136:23: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
long     atol(const char *);
                         ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:136:23: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:136:23: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:139:20: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
         atoll(const char *);
                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:139:20: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:139:20: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:141:26: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
void    *bsearch(const void *__key, const void *__base, size_t __nel,
                            ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:141:26: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:141:26: note: insert '_Nonnull' if the pointer should never be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:141:45: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
void    *bsearch(const void *__key, const void *__base, size_t __nel,
                                               ^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:141:45: note: insert '_Nullable' if the pointer may be null
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/stdlib.h:141:45: note: insert '_Nonnull' if the pointer should never be null
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
*** Error code 1
1 error
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_cvsdiff2patch/cvsdiff2patch/work/cvsdiff2patch-1.0.1" && /opt/local/bin/bsdmake -j16 all 
Exit code: 2
Error: Failed to build cvsdiff2patch: command execution failed
DEBUG: Error code: CHILDSTATUS 34471 2

[ryandesign (Ryan Carsten Schmidt)]

Do we still need this software? Are people still using cvs?

[cooljeanius (Eric Gallager)]

Replying to ryandesign:

Do we still need this software? Are people still using cvs?

Probably not. I'm not a fan of deleting stuff, but I also wouldn't object to this port being deleted if that's the direction people decide to go with it.