xraylib @3.3.0_1 update to upstream 4.1.1 and add python39 variant

[joefowler (Joe Fowler)]

Existing xraylib @3.3.0_1 does not have a python39 variant. One should be added. Also, the upstream code is version 4.1.1 now, and this patch upgrades to that version.

I am willing to be the maintainer. I am not very adept at macports, but I do already maintain packages ifeffit and demeter, two other x-ray science tools.

[joefowler (Joe Fowler)]

Patch to Portfile

[joefowler (Joe Fowler)]

Why is the post-extract sed command now removed from the Portfile?

The pure Python executable xraylib that appeared in earlier versions of xraylib is now gone. Its header needed to have "/usr/bin/env python" replaced with the mac ports Python, but that's all irrelevant now...as far as I can tell. The file was removed in September 2017 (see ​xraylib issue 58).

[ryandesign (Ryan Carsten Schmidt)]

Thanks, I'll commit it with some changes.

The revision should be set to 0 when updating the version.

There's no need to put quotation marks around the value that you set configure.cmd (or any other MacPorts option) to. (You only need that when setting your own Tcl variables that are not MacPorts options.)

It's preferable to use use_autoreconf yes and adjust autoreconf.args if necessary rather than doing it manually by overriding configure.cmd. The default value of autoreconf.args is --install --verbose so I don't think we'll need to change them here.

I'll fix the description of the python39 variant and set that as the default python variant to match what we do in other ports now.

[ryandesign (Ryan Carsten Schmidt)]

In ea3baec5647cf76cc544408e35d16d883a9f3920/macports-ports (master):

xraylib: Update to 4.1.1 and add python39 variant

Closes: #63546

[joefowler (Joe Fowler)]

Ryan: thanks so much for checking my patch. I forgot to reset the revision number, of course. More importantly, I appreciate you identifying the use_autoreconf system.