Opened 8 weeks ago

Last modified 3 weeks ago

#63597 assigned defect

graphviz-gui @2.49.1_0.darwin_15.x86_64: unknown type name 'NSToolbarItemIdentifier'

Reported by: thetrial (alabay) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version: 2.7.1
Keywords: elcapitan legacy-os Cc: ryandesign (Ryan Schmidt), sambthompson (Sam Thompson)
Port: graphviz-gui

Description

Graphviz-gui is not building. I’ll attach the logfile.

error: unknown type name 'NSToolbarItemIdentifier'; did you mean 'NSTouchBarItemIdentifier'?

Attachments (1)

main.log (401.4 KB) - added by thetrial (alabay) 8 weeks ago.

Download all attachments as: .zip

Change History (11)

Changed 8 weeks ago by thetrial (alabay)

Attachment: main.log added

comment:1 Changed 8 weeks ago by evanmiller (Evan Miller)

NSToolbarItemIdentifier is an NSString typedef that was introduced in 10.13: https://developer.apple.com/documentation/appkit/nstoolbaritemidentifier?language=objc

There shouldn't be any problem deploying to 10.11, but right now it looks like the code base is assuming a 10.13+ SDK.

The error in question originates from this change:

https://gitlab.com/graphviz/graphviz/-/commit/544035e049fb38ab4243c5ae225aa48f2ab3b4ac

comment:2 Changed 8 weeks ago by mascguy (Christopher Nielsen)

Cc: mascguy added

comment:3 Changed 8 weeks ago by mascguy (Christopher Nielsen)

Owner: changed from ryandesign to mascguy

comment:4 Changed 8 weeks ago by mascguy (Christopher Nielsen)

Cc: ryandesign added; mascguy removed

comment:5 Changed 8 weeks ago by mascguy (Christopher Nielsen)

Interestingly enough, graphviz-gui is only failing to build on one of our buildbots - macOS 10.11:

https://ports.macports.org/port/graphviz-gui/details/

With the details here, though it looks like it's the same issue:

https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/155777/steps/install-port/logs/stdio

Ryan/anyone, thoughts as to what the "right" fix for this should be...?

comment:6 Changed 8 weeks ago by evanmiller (Evan Miller)

Try

reinplace "s|NSToolbarItemIdentifier|NSString *|" macosx/GVAttributeInspectorController.h

comment:7 in reply to:  6 Changed 8 weeks ago by mascguy (Christopher Nielsen)

Replying to evanmiller:

Try

reinplace "s|NSToolbarItemIdentifier|NSString *|" macosx/GVAttributeInspectorController.h

Wow, didn't expect it to be quite that easy! LOL

I'll test this in the coming days. Thanks so much Evan!

Last edited 7 weeks ago by mascguy (Christopher Nielsen) (previous) (diff)

comment:8 Changed 5 weeks ago by evanmiller (Evan Miller)

@mascguy Did you try it? The regex might need a "g" at the end for a global replacement.

comment:9 in reply to:  8 Changed 4 weeks ago by mascguy (Christopher Nielsen)

Replying to evanmiller:

@mascguy Did you try it? The regex might need a "g" at the end for a global replacement.

Haven't had a chance to tackle this yet. Presently preoccupied with foundational ports, which are failing to build on some of our buildbots. Which in turn block downstream dependents from being built, etc. Starting to see the light of day though.

However, this is still on my near-term to-do list, as I'd certainly love to eliminate these build failures too!

comment:10 Changed 3 weeks ago by sambthompson (Sam Thompson)

Cc: sambthompson added
Note: See TracTickets for help on using tickets.