Opened 2 years ago

Closed 2 years ago

#63810 closed enhancement (fixed)

HexFiend: Support arm64

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: HexFiend

Description

HexFiend says:

supported_archs x86_64

This was done 7 years ago to disable i386 builds; see #46106.

Could it build on arm64?

Attachments (2)

patch-xcode-disable-sparkle.diff (4.6 KB) - added by tomio-arisaka (Tomio Arisaka) 2 years ago.
patch-enable-build-on-high-sierra.diff (14.7 KB) - added by tomio-arisaka (Tomio Arisaka) 2 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 2 years ago by tomio-arisaka (Tomio Arisaka)

I tried to build the development version of HexFiend.

$ sw_vers
ProductName:	macOS
ProductVersion:	11.6.5
BuildVersion:	20G527
$ 
$ xcodebuild -version
Xcode 12.4
Build version 12D4e
$ 
$ port installed hexfiend
The following ports are currently installed:
  HexFiend @2.14.1b_0
  HexFiend @872e6ab973370cf9c51e9f16c4b771c4454f237a_0 (active)
$ 
$ file /Applications/MacPorts/Hex\ Fiend.app/Contents/MacOS/Hex\ Fiend 
/Applications/MacPorts/Hex Fiend.app/Contents/MacOS/Hex Fiend: Mach-O 64-bit executable arm64

This is my example:

$ diff -u Portfile.orig Portfile
--- Portfile.orig	2020-12-22 23:37:23.000000000 +0900
+++ Portfile	2022-04-07 16:41:22.000000000 +0900
@@ -5,10 +5,10 @@
 PortGroup       xcodeversion 1.0
 PortGroup       github 1.0
 
-github.setup    ridiculousfish HexFiend 2.14.1b v
-checksums       rmd160  ef52e8fe7722c06385c2fa3765bed93d68fbde75 \
-                sha256  45e8d8fda54ae28c6b0d251c4344cb9d9c8a8bf3155e0161dfdcf731e4b006fa \
-                size    4600384
+github.setup    HexFiend HexFiend 872e6ab973370cf9c51e9f16c4b771c4454f237a
+checksums       rmd160  37a78876896508d5da904b7b3affb1c40707e125 \
+                sha256  22c2342c910331d859add9ae582bbafbc89208a119ec6a3a309230b8206abcb4 \
+                size    4629610
 
 epoch           1
 categories      editors aqua
@@ -27,29 +27,35 @@
     * Data inspector. Interpret data as integer or floating point, signed or unsigned, big or little endian...\n\
     * Smooth scrolling. No separate pages - scroll like any text document.
 
-supported_archs x86_64
+supported_archs x86_64 arm64
 
 patch.pre_args  -p1
-patchfiles      0001-xcode-Disable-Sparkle.patch
+if {${os.platform} eq "darwin"} {
+    if {${os.major} == 17} {
+        patchfiles      patch-enable-build-on-high-sierra.diff
+    } else {
+        patchfiles      patch-xcode-disable-sparkle.diff
+    }
+}
 
 description     HexFiend is a fast and clever hex editor
 
-xcode.scheme        Release+MAS
-xcode.configuration Release+MAS
+xcode.scheme        Release
+xcode.configuration Release
 xcode.build.settings \
     CODE_SIGN_IDENTITY=- \
     CODE_SIGN_STYLE=Manual
 build.pre_args -derivedDataPath ${worksrcpath}
 
 destroot {
-    copy "${worksrcpath}/build/Release+MAS/Hex Fiend.app" ${destroot}${applications_dir}
+    copy "${worksrcpath}/build/Release/Hex Fiend.app" ${destroot}${applications_dir}
     xinstall -d ${destroot}${prefix}/share/doc/${name}
     xinstall -m 644 ${worksrcpath}/License.txt ${destroot}${prefix}/share/doc/${name}
 }
 
-if {${os.platform} ne "darwin" || ${os.major} < 18} {
+if {${os.platform} ne "darwin" || ${os.major} < 17} {
     pre-fetch {
-        ui_error "${subport} @${version} only works with macOS 10.14 Mojave or later."
+        ui_error "${subport} @${version} only works with macOS 10.13 High Sierra or later."
         return -code error "incompatible macOS version"
     }
 }

Changed 2 years ago by tomio-arisaka (Tomio Arisaka)

Changed 2 years ago by tomio-arisaka (Tomio Arisaka)

comment:2 Changed 2 years ago by Clemens Lang <neverpanic@…>

Resolution: fixed
Status: assignedclosed

In 9c20fd8fd9919f4d60b29f557ce8194b0fdc7720/macports-ports (master):

HexFiend: Update to 2.15.0b1

Closes: #63810

Note: See TracTickets for help on using tickets.