Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#64198 closed defect (fixed)

podman-compose missing dotenv depeendency

Reported by: urkle (Edward Rudd) Owned by: judaew (Vadym-Valdis Yudaiev)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: podman-compose

Description

podman-compose uses the dotenv python package, however it is not added as a dependency.

Further the py-dotenv package isn't available yet for python 3.10 (which is what podman-compose is building against)

I have tested locally by changing the portfile to use python 39 and add py39-pythong-dotenv as a dependency and now it works locally.

Attachments (1)

patch.diff (881 bytes) - added by urkle (Edward Rudd) 2 years ago.
patch

Download all attachments as: .zip

Change History (4)

Changed 2 years ago by urkle (Edward Rudd)

Attachment: patch.diff added

patch

comment:1 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: set to judaew
Port: podman-compose added
Status: newassigned

The proposed patch looks good to me. Unless there is a good reason why podman-compose needed to use python 3.10, it should use the same python version specified in the python-1.0 portgroup:

https://github.com/macports/macports-ports/blob/master/_resources/port1.0/group/python-1.0.tcl#L76

comment:2 Changed 2 years ago by Vadim-Valdis Yudaev <judaew@…>

Resolution: fixed
Status: assignedclosed

In 1a0b8db813ecb50369459dfadfb4824f490f23fb/macports-ports (master):

podman-compose: Add missing dependency

Closed: #64198

comment:3 Changed 2 years ago by judaew (Vadym-Valdis Yudaiev)

Edward, thanks for the patch

Note: See TracTickets for help on using tickets.